pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: meskill (@meskill) <noreply+meskill@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2058: feat(resharding): add initial setup for resumable resharding tasks
Date: Wed, 18 Nov 2026 23:21:15 +0000
Message-ID: <gh-pgdogdev-pgdog-2058-rc4622217489@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2058-rc4617871404@github.com>
References: <gh-pgdogdev-pgdog-2058@github.com>
	<gh-pgdogdev-pgdog-2058-rc4617871404@github.com>

(on pgdog/src/backend/replication/logical/run/store.rs:323)

I explain why it looks how it looks: exactly because of making everything not pub. 
It's a test and ConfigSnapshot is from another module with private fields and we can't create the object explicitly and can't have the constructor not used by anyone, so clanker politely put the hack with json parsing here (tokens are saved!).

I'll look for a better way to do this, it's a hack obviously

view thread (38+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2058-rc4622217489@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2058-rc4622217489@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox