pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2064: fix: don't route by cols belonging to CTEs / derived tables if same name as sharded table & key
Date: Wed, 18 Nov 2026 20:49:32 +0000
Message-ID: <gh-pgdogdev-pgdog-2064-c6991230843@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2064@github.com>
References: <gh-pgdogdev-pgdog-2064@github.com>

<!-- metal-bench -->

**Metal bench (arm64) failed.** 17 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 18.88 (-0.3% ± 0.9%) | 17,735 (+0.2% ± 0.5%) | 31,381 (-0.0% ± 0.04%) | 30,528 (-0.7% ± 1.5%) | 51,149 (+0.1% ± 0.6%) |  |
| lb |  | 19.36 (+0.2% ± 0.5%) | 18,265 (-0.1% ± 0.8%) | 32,294 (-0.0% ± 0.07%) | 31,030 (+0.4% ± 1.2%) | 52,240 (-0.2% ± 0.3%) |  |
| sharding-w2 |  | 32.41 (+0.9% ± 1.8%) | 42,669 (-0.1% ± 1.3%) | 94,934 (+0.0% ± 0.02%) | 41,592 (+2.0% ± 2.8%) | 53,706 (-0.0% ± 0.04%) | 1.549 (-0.1% ± 0.2%) |
| sharding-w8 | 244,950 (+0.3% ± 0.2%) | 29.21 (-0.1% ± 0.7%) | 44,122 (+0.2% ± 2.4%) | 50,494 (+0.0% ± 0.03%) | 36,554 (-0.3% ± 1.2%) | 42,360 (-0.0% ± 0.09%) | 0.1672 (-1.1% ± 3.6%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,358 (+0.4% ± 1.7%) | 2,640 (+0.2% ± 0.7%) |  |
| lb | 7,657 (-0.4% ± 2.1%) | 2,678 (-0.1% ± 0.8%) |  |
| sharding-w2 | 17,293 (-0.6% ± 3.4%) | 4,109 (-0.5% ± 1.6%) |  |
| sharding-w8 | 20,428 (+1.2% ± 8.6%) | 4,203 (+1.0% ± 4.6%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::cte | alloc_bytes | 1,264 | 1,156 | **+9.34% ± 0.00%** | +1% |
| extended_cached::cte | instructions | 23,932 | 23,657 | **+1.16% ± 0.00%** | +1% |
| extended_cached::join | alloc_bytes | 1,572 | 1,540 | **+2.08% ± 0.00%** | +1% |
| extended_cold::cte | alloc_bytes | 1,815 | 1,707 | **+6.33% ± 0.00%** | +1% |
| extended_cold::join | alloc_bytes | 2,150 | 2,118 | **+1.51% ± 0.00%** | +1% |
| extended_evicting::cte | alloc_bytes | 1,775 | 1,667 | **+6.48% ± 0.00%** | +1% |
| extended_evicting::cte | instructions | 48,753 | 48,187 | **+1.17% ± 0.00%** | +1% |
| extended_evicting::join | alloc_bytes | 2,110 | 2,078 | **+1.54% ± 0.00%** | +1% |
| full_extended_cached::cte | alloc_bytes | 7,459 | 7,351 | **+1.47% ± 0.00%** | +1% |
| full_named_cached::aggregate | instructions | 136,186 | 134,377 | **+1.35% ± 0.00%** | +1% |
| full_named_cached::cte | alloc_bytes | 7,336 | 7,228 | **+1.49% ± 0.00%** | +1% |
| full_named_cached::update_by_key | instructions | 61,805 | 60,503 | **+2.15% ± 0.00%** | +1% |
| full_simple::cte | alloc_bytes | 7,498 | 7,390 | **+1.46% ± 0.00%** | +1% |
| full_simple::order_limit_offset | instructions | 195,469 | 192,751 | **+1.41% ± 0.00%** | +1% |
| simple_cold::cte | alloc_bytes | 1,775 | 1,667 | **+6.48% ± 0.00%** | +1% |
| simple_cold::cte | instructions | 47,013 | 46,526 | **+1.05% ± 0.00%** | +1% |
| simple_cold::join | alloc_bytes | 2,110 | 2,078 | **+1.54% ± 0.00%** | +1% |

Microbench: 490 of 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 113.9 KB | 112.3 KB | **-1.6 KB** |
| sharding-w2 | 168.4 KB | 168.9 KB | **+0.6 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.1 KB | 20.0 KB | -0.1 KB |
| tokio | 18.6 KB | 18.2 KB | -0.4 KB |
| pgdog::backend::pool | 17.5 KB | 17.4 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.4 KB | 10.2 KB | -0.2 KB |
| rustls (TLS) | 8.5 KB | 8.3 KB | -0.2 KB |
| pgdog::frontend (other) | 7.9 KB | 7.8 KB | -0.1 KB |
| pgdog::backend::server | 7.6 KB | 7.6 KB | -0.1 KB |
| other | 6.1 KB | 6.1 KB | +0.0 KB |
| everything else | 17.1 KB | 16.6 KB | -0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.5 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.0 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.3 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.2 KB | 29.3 KB | +0.1 KB |
| pgdog::frontend::client::query_engine | 21.1 KB | 21.3 KB | +0.2 KB |
| tokio | 18.7 KB | 18.6 KB | -0.1 KB |
| pgdog::backend::pool | 18.2 KB | 18.3 KB | +0.1 KB |
| aws-lc (TLS crypto) | 13.3 KB | 13.2 KB | -0.1 KB |
| other | 9.9 KB | 9.9 KB | +0.0 KB |
| pgdog::frontend (other) | 9.1 KB | 8.9 KB | -0.1 KB |
| pgdog::backend::server | 8.0 KB | 8.1 KB | +0.1 KB |
| everything else | 40.9 KB | 41.1 KB | +0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.0 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.3 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | +0.1 KB |

</details>

<details><summary>lb flamegraph vs 8cfcf31f</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...).
</details>
<details><summary>microbench flamegraph vs 8cfcf31f</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...).
</details>
<details><summary>pooler flamegraph vs 8cfcf31f</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...).
</details>
<details><summary>sharding-w2 flamegraph vs 8cfcf31f</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...).
</details>
<details><summary>sharding-w8 flamegraph vs 8cfcf31f</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/jk-router-derived-table-aliases/39d917121f306cddf...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-router-derived-table...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-router-derived-table...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-router-derived-table...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-router-derived-table...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-router-derived-table...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/jk-router-derived-table...)
</details>

Compared 39d91712 with 8cfcf31f on m8g.metal-24xl (spot).


view thread (6+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2064-c6991230843@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2064-c6991230843@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox