pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2064: fix: don't route by cols belonging to CTEs / derived tables if same name as sharded table & key
Date: Wed, 18 Nov 2026 23:05:20 +0000
Message-ID: <gh-pgdogdev-pgdog-2064-c6994245584@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2064@github.com>
References: <gh-pgdogdev-pgdog-2064@github.com>
<!-- metal-bench-x86 -->
**Metal bench (x86) failed.** 16 of 520 measures outside bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 34.92 (+0.2% ± 0.2%) | 22,865 (+0.3% ± 0.9%) | 32,734 (-0.0% ± 0.02%) | 58,400 (+0.2% ± 0.4%) | 38,531 (-0.1% ± 0.3%) | |
| lb | | 35.89 (-0.2% ± 0.2%) | 24,000 (-0.3% ± 0.7%) | 33,700 (+0.0% ± 0.02%) | 59,225 (-0.2% ± 0.1%) | 39,229 (+0.0% ± 0.3%) | |
| sharding-w2 | | 56.61 (-0.1% ± 1.6%) | 52,785 (+0.1% ± 1.9%) | 98,604 (+0.0% ± 0.01%) | 73,290 (-0.2% ± 2.7%) | 43,065 (-0.0% ± 0.1%) | 1.391 (+0.0% ± 0.5%) |
| sharding-w8 | 146,408 (-0.8% ± 2.1%) | 48.56 (+0.4% ± 1.4%) | 57,965 (+0.1% ± 1.9%) | 54,108 (-0.0% ± 0.2%) | 65,274 (+0.6% ± 1.2%) | 34,220 (+0.0% ± 0.2%) | 0.1723 (-0.1% ± 1.9%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,477 (+0.6% ± 1.0%) | 3,629 (+0.1% ± 0.4%) | |
| lb | 77,395 (-0.5% ± 0.4%) | 3,748 (-0.0% ± 0.3%) | |
| sharding-w2 | 159,547 (+0.0% ± 4.8%) | 6,062 (+0.2% ± 0.8%) | |
| sharding-w8 | 120,601 (-0.3% ± 1.7%) | 4,892 (+0.1% ± 0.5%) | |
</details>
| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::cte | alloc_bytes | 1,296 | 1,180 | **+9.83% ± 0.00%** | +1% |
| extended_cached::cte | instructions | 24,219 | 23,906 | **+1.31% ± 0.00%** | +1% |
| extended_cached::join | alloc_bytes | 1,596 | 1,564 | **+2.05% ± 0.00%** | +1% |
| extended_cold::cte | alloc_bytes | 1,847 | 1,731 | **+6.70% ± 0.00%** | +1% |
| extended_cold::cte | instructions | 48,591 | 47,994 | **+1.24% ± 0.00%** | +1% |
| extended_cold::join | alloc_bytes | 2,174 | 2,142 | **+1.49% ± 0.00%** | +1% |
| extended_evicting::cte | alloc_bytes | 1,807 | 1,691 | **+6.86% ± 0.00%** | +1% |
| extended_evicting::join | alloc_bytes | 2,134 | 2,102 | **+1.52% ± 0.00%** | +1% |
| full_extended_cached::cte | alloc_bytes | 7,491 | 7,375 | **+1.57% ± 0.00%** | +1% |
| full_named_cached::aggregate | instructions | 142,462 | 140,677 | **+1.27% ± 0.00%** | +1% |
| full_named_cached::cte | alloc_bytes | 7,368 | 7,252 | **+1.60% ± 0.00%** | +1% |
| full_simple::cte | alloc_bytes | 7,530 | 7,414 | **+1.56% ± 0.00%** | +1% |
| full_simple::cte | instructions | 106,116 | 104,759 | **+1.29% ± 0.00%** | +1% |
| simple_cold::cte | alloc_bytes | 1,807 | 1,691 | **+6.86% ± 0.00%** | +1% |
| simple_cold::cte | instructions | 47,847 | 47,368 | **+1.01% ± 0.00%** | +1% |
| simple_cold::join | alloc_bytes | 2,134 | 2,102 | **+1.52% ± 0.00%** | +1% |
Microbench: 491 of 507 measures within bounds.
<details><summary>Microbench latency: 4 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::group_by | 2,888 ns | 2,742 ns | +5.33% ± 0.77% | +0.03% ± 0.00% |
| extended_cached::subquery | 3,164 ns | 3,020 ns | +4.78% ± 4.69% | +0.05% ± 0.00% |
| full_simple::aggregate | 26,788 ns | 27,974 ns | -4.23% ± 1.75% | +0.09% ± 0.00% |
| extended_cold::subquery | 6,148 ns | 5,914 ns | +3.97% ± 2.33% | +0.66% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 106.4 KB | 108.3 KB | **+1.9 KB** |
| sharding-w2 | 166.2 KB | 165.8 KB | **-0.4 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.8 KB | 21.2 KB | +0.4 KB |
| tokio | 17.4 KB | 17.4 KB | +0.1 KB |
| pgdog::backend::pool | 16.2 KB | 17.0 KB | +0.8 KB |
| pgdog::frontend (other) | 8.6 KB | 8.7 KB | +0.1 KB |
| pgdog::backend::server | 7.2 KB | 7.5 KB | +0.3 KB |
| rustls (TLS) | 6.9 KB | 7.2 KB | +0.3 KB |
| aws-lc (TLS crypto) | 7.6 KB | 7.2 KB | -0.4 KB |
| other | 5.8 KB | 5.9 KB | +0.1 KB |
| everything else | 15.9 KB | 16.1 KB | +0.2 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.6 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.6 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.8 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | +0.0 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.4 KB | 27.2 KB | -0.2 KB |
| pgdog::frontend::client::query_engine | 22.9 KB | 23.1 KB | +0.2 KB |
| tokio | 18.1 KB | 17.9 KB | -0.1 KB |
| pgdog::backend::pool | 18.1 KB | 17.8 KB | -0.3 KB |
| other | 11.0 KB | 10.4 KB | -0.6 KB |
| aws-lc (TLS crypto) | 10.3 KB | 10.3 KB | +0.0 KB |
| pgdog::frontend (other) | 10.1 KB | 10.1 KB | +0.1 KB |
| jemalloc | 9.2 KB | 9.5 KB | +0.2 KB |
| everything else | 39.1 KB | 39.4 KB | +0.3 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.6 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.5 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.9 KB | +0.0 KB |
</details>
<details><summary>lb flamegraph vs 8cfcf31f</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...).
</details>
<details><summary>microbench flamegraph vs 8cfcf31f</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...).
</details>
<details><summary>pooler flamegraph vs 8cfcf31f</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...).
</details>
<details><summary>sharding-w2 flamegraph vs 8cfcf31f</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...).
</details>
<details><summary>sharding-w8 flamegraph vs 8cfcf31f</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-router-derived-table-aliases/39d917121f306...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-router-derived-t...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-router-derived-t...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-router-derived-t...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-router-derived-t...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-router-derived-t...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-router-derived-t...)
</details>
Compared 39d91712 with 8cfcf31f on c7a.metal-48xl (spot).
view thread (6+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2064-c6994245584@github.com>
Permalink: ../gh-pgdogdev-pgdog-2064-c6994245584@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox