pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2066: fix: support cross-shard subqueries that only return constants (e.g., Rails .limit(N).count)
Date: Wed, 18 Nov 2026 22:36:41 +0000
Message-ID: <gh-pgdogdev-pgdog-2066-c6993677216@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2066@github.com>
References: <gh-pgdogdev-pgdog-2066@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 25.87 (-0.1% ± 0.6%) | 18,652 (+0.1% ± 0.1%) | 32,813 (-0.0% ± 0.03%) | 33,700 (-0.2% ± 0.9%) | 36,499 (+0.1% ± 0.4%) |  |
| lb |  | 26.29 (+0.1% ± 0.5%) | 19,244 (+0.1% ± 0.1%) | 33,785 (-0.0% ± 0.02%) | 33,842 (+0.1% ± 0.9%) | 37,259 (+0.3% ± 0.7%) |  |
| sharding-w2 |  | 42.09 (+0.2% ± 0.8%) | 46,958 (+0.5% ± 1.2%) | 98,726 (+0.0% ± 0.01%) | 38,627 (+0.0% ± 2.3%) | 40,172 (+0.0% ± 0.4%) | 1.525 (+0.0% ± 0.3%) |
| sharding-w8 | 207,093 (+0.2% ± 0.8%) | 32.9 (-0.0% ± 0.4%) | 46,035 (-0.1% ± 0.7%) | 53,053 (-0.0% ± 0.03%) | 31,164 (+0.0% ± 0.7%) | 32,487 (-0.0% ± 0.07%) | 0.1715 (-0.3% ± 1.1%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 3,301 (+0.3% ± 0.7%) | 1,102 (+0.1% ± 0.4%) | 39,155 (+0.0% ± 0.3%) |
| lb | 3,564 (-0.1% ± 0.7%) | 1,153 (-0.3% ± 0.7%) | 39,416 (+0.4% ± 0.6%) |
| sharding-w2 | 6,528 (+0.5% ± 0.9%) | 1,588 (+0.3% ± 0.7%) | 112,098 (+0.9% ± 2.2%) |
| sharding-w8 | 3,404 (-0.1% ± 1.7%) | 865 (-0.1% ± 1.0%) | 177,764 (-0.0% ± 0.7%) |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 1 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| simple_cold::aggregate | 8,785 ns | 9,061 ns | -3.04% ± 0.38% | +0.00% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 115.4 KB | 116.1 KB | **+0.7 KB** |
| sharding-w2 | 169.2 KB | 168.8 KB | **-0.5 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 22.8 KB | 23.0 KB | +0.2 KB |
| tokio | 18.4 KB | 18.6 KB | +0.2 KB |
| pgdog::backend::pool | 18.1 KB | 18.1 KB | -0.1 KB |
| pgdog::frontend (other) | 9.8 KB | 9.6 KB | -0.1 KB |
| aws-lc (TLS crypto) | 8.8 KB | 8.9 KB | +0.1 KB |
| pgdog::backend::server | 7.9 KB | 8.2 KB | +0.3 KB |
| rustls (TLS) | 7.9 KB | 7.9 KB | +0.0 KB |
| other | 5.9 KB | 5.8 KB | -0.1 KB |
| everything else | 15.8 KB | 15.9 KB | +0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.3 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.4 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 5.2 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.8 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 28.4 KB | 28.1 KB | -0.4 KB |
| pgdog::frontend::client::query_engine | 23.8 KB | 23.8 KB | +0.0 KB |
| pgdog::backend::pool | 18.9 KB | 18.3 KB | -0.6 KB |
| tokio | 18.8 KB | 18.1 KB | -0.7 KB |
| pgdog::frontend (other) | 10.9 KB | 11.1 KB | +0.1 KB |
| aws-lc (TLS crypto) | 10.2 KB | 10.4 KB | +0.2 KB |
| other | 10.1 KB | 10.3 KB | +0.2 KB |
| pgdog::backend::server | 8.4 KB | 8.8 KB | +0.4 KB |
| everything else | 39.7 KB | 39.8 KB | +0.1 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.8 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.6 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.1 KB |

</details>

<details><summary>lb flamegraph vs 6b0e24d7</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...).
</details>
<details><summary>microbench flamegraph vs 6b0e24d7</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...).
</details>
<details><summary>pooler flamegraph vs 6b0e24d7</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...).
</details>
<details><summary>sharding-w2 flamegraph vs 6b0e24d7</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...).
</details>
<details><summary>sharding-w8 flamegraph vs 6b0e24d7</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-rails-limit-count-const-return-fix/521afa7...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-rails-limit-coun...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-rails-limit-coun...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-rails-limit-coun...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-rails-limit-coun...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-rails-limit-coun...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-rails-limit-coun...)
</details>

Compared 521afa7e with 6b0e24d7 on m7i.metal-48xl (spot).


view thread (6+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2066-c6993677216@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2066-c6993677216@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox