pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2068: fix: extra ReadyForQuery in shard key update transaction
Date: Wed, 18 Nov 2026 23:01:57 +0000
Message-ID: <gh-pgdogdev-pgdog-2068-c6994178406@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2068@github.com>
References: <gh-pgdogdev-pgdog-2068@github.com>

<!-- metal-bench -->

**Metal bench (arm64) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 18.83 (-1.1% ± 0.7%) | 17,723 (+0.0% ± 0.4%) | 31,393 (+0.0% ± 0.03%) | 30,416 (-1.9% ± 1.3%) | 51,143 (+0.2% ± 0.4%) |  |
| lb |  | 19.55 (-0.4% ± 2.4%) | 18,385 (+0.3% ± 1.1%) | 32,295 (-0.0% ± 0.04%) | 31,430 (-0.9% ± 4.1%) | 52,088 (-0.0% ± 0.4%) |  |
| sharding-w2 |  | 32.54 (+0.4% ± 1.9%) | 43,635 (+0.3% ± 2.0%) | 94,904 (-0.0% ± 0.01%) | 40,883 (+0.5% ± 2.3%) | 53,707 (+0.0% ± 0.3%) | 1.55 (+0.0% ± 0.2%) |
| sharding-w8 | 244,025 (-0.4% ± 0.4%) | 29.19 (+0.2% ± 0.5%) | 44,332 (+0.9% ± 0.9%) | 50,473 (+0.0% ± 0.07%) | 36,262 (-0.6% ± 0.3%) | 42,407 (+0.0% ± 0.2%) | 0.1699 (+0.1% ± 2.4%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,386 (-0.3% ± 1.3%) | 2,646 (+0.2% ± 0.4%) |  |
| lb | 7,823 (+0.5% ± 3.7%) | 2,705 (+0.3% ± 1.2%) |  |
| sharding-w2 | 18,001 (+0.4% ± 4.8%) | 4,136 (+0.4% ± 2.3%) |  |
| sharding-w8 | 19,848 (+2.9% ± 6.7%) | 4,050 (+1.4% ± 2.5%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 1 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| full_simple::order_limit_offset | 28,558 ns | 27,520 ns | +3.78% ± 2.10% | +0.00% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 113.8 KB | 113.4 KB | **-0.3 KB** |
| sharding-w2 | 168.0 KB | 167.1 KB | **-0.9 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.2 KB | 20.1 KB | -0.1 KB |
| tokio | 18.5 KB | 18.3 KB | -0.2 KB |
| pgdog::backend::pool | 17.4 KB | 17.7 KB | +0.2 KB |
| aws-lc (TLS crypto) | 10.3 KB | 10.0 KB | -0.3 KB |
| rustls (TLS) | 8.5 KB | 8.3 KB | -0.2 KB |
| pgdog::frontend (other) | 7.9 KB | 7.8 KB | -0.1 KB |
| pgdog::backend::server | 7.7 KB | 7.8 KB | +0.1 KB |
| other | 6.1 KB | 6.1 KB | +0.0 KB |
| everything else | 17.1 KB | 17.3 KB | +0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.5 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.1 KB | -0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.1 KB | 28.8 KB | -0.3 KB |
| pgdog::frontend::client::query_engine | 21.1 KB | 21.1 KB | +0.1 KB |
| tokio | 18.6 KB | 18.7 KB | +0.1 KB |
| pgdog::backend::pool | 18.0 KB | 17.9 KB | -0.1 KB |
| aws-lc (TLS crypto) | 13.4 KB | 12.8 KB | -0.6 KB |
| other | 9.9 KB | 10.2 KB | +0.4 KB |
| pgdog::frontend (other) | 8.9 KB | 8.9 KB | -0.1 KB |
| pgdog::backend::server | 8.1 KB | 8.0 KB | -0.1 KB |
| everything else | 40.9 KB | 40.7 KB | -0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 3.9 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.2 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs 068e28fd</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...).
</details>
<details><summary>microbench flamegraph vs 068e28fd</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...).
</details>
<details><summary>pooler flamegraph vs 068e28fd</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...).
</details>
<details><summary>sharding-w2 flamegraph vs 068e28fd</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...).
</details>
<details><summary>sharding-w8 flamegraph vs 068e28fd</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-fix-extra-rfq/57e929b16a5acf964a48abe09d18f...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-fix-extra-rfq/57e...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-fix-extra-rfq/57e...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-fix-extra-rfq/57e...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-fix-extra-rfq/57e...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-fix-extra-rfq/57e...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-fix-extra-rfq/57e...)
</details>

Compared 57e929b1 with 068e28fd on c8g.metal-24xl (spot).


view thread (6+ messages)

Message-ID: <gh-pgdogdev-pgdog-2068-c6994178406@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2068-c6994178406@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox