pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2070: feat: support two-table cross-shard JOINs (JOIN, LEFT JOIN, CROSS JOIN, NATURAL JOIN)
Date: Thu, 19 Nov 2026 13:14:35 +0000
Message-ID: <gh-pgdogdev-pgdog-2070-c7010186114@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2070@github.com>
References: <gh-pgdogdev-pgdog-2070@github.com>
<!-- metal-bench-x86 -->
**Metal bench (x86) failed.** 2 of 520 measures outside bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 25.8 (+0.1% ± 0.3%) | 18,685 (+0.5% ± 0.2%) | 32,752 (-0.0% ± 0.03%) | 33,577 (-0.1% ± 0.8%) | 36,478 (-0.0% ± 0.6%) | |
| lb | | 26.17 (+0.0% ± 0.3%) | 19,172 (-0.0% ± 0.5%) | 33,627 (-0.3% ± 0.9%) | 33,691 (+0.1% ± 0.5%) | 37,332 (+0.3% ± 0.4%) | |
| sharding-w2 | | 42.15 (+0.2% ± 1.4%) | 47,346 (+0.3% ± 0.7%) | 98,722 (+0.0% ± 0.01%) | 38,615 (-0.2% ± 2.6%) | 40,132 (-0.0% ± 0.2%) | 1.525 (-0.1% ± 0.3%) |
| sharding-w8 | 205,422 (-0.0% ± 1.0%) | 33.14 (+0.1% ± 0.2%) | 46,393 (+0.2% ± 0.5%) | 53,069 (-0.0% ± 0.07%) | 31,437 (-0.0% ± 0.1%) | 32,510 (+0.0% ± 0.3%) | 0.1717 (-0.1% ± 3.1%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 3,184 (+1.0% ± 0.9%) | 1,081 (+0.6% ± 1.0%) | 40,422 (+0.8% ± 0.5%) |
| lb | 3,307 (-2.7% ± 0.5%) | 1,105 (-2.8% ± 0.9%) | 41,240 (+1.9% ± 0.4%) |
| sharding-w2 | 6,250 (-0.9% ± 1.9%) | 1,486 (-2.5% ± 1.8%) | 116,867 (+1.3% ± 1.9%) |
| sharding-w8 | 3,476 (-0.6% ± 1.6%) | 850 (-0.7% ± 1.1%) | 179,906 (+0.4% ± 0.9%) |
</details>
| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| full_named_cached::aggregate | instructions | 143,612 | 141,384 | **+1.58% ± 0.00%** | +1% |
| full_named_cached::delete_by_key | instructions | 63,426 | 62,195 | **+1.98% ± 0.00%** | +1% |
Microbench: 505 of 507 measures within bounds.
<details><summary>Microbench latency: 6 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::group_by | 3,004 ns | 2,795 ns | +7.48% ± 0.55% | +0.10% ± 0.00% |
| extended_cached::having | 3,234 ns | 3,012 ns | +7.38% ± 1.01% | +0.09% ± 0.00% |
| extended_cached::having_distinct_limit | 3,587 ns | 3,388 ns | +5.88% ± 0.50% | +0.08% ± 0.00% |
| extended_evicting::group_by | 7,116 ns | 6,753 ns | +5.38% ± 0.26% | +0.05% ± 0.00% |
| extended_cold::group_by | 6,900 ns | 6,582 ns | +4.84% ± 0.60% | +0.05% ± 0.00% |
| simple_cold::group_by | 6,701 ns | 6,396 ns | +4.78% ± 0.67% | +0.05% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 116.3 KB | 115.1 KB | **-1.2 KB** |
| sharding-w2 | 171.0 KB | 170.6 KB | **-0.4 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 22.8 KB | 22.8 KB | -0.1 KB |
| pgdog::backend::pool | 18.3 KB | 18.4 KB | +0.1 KB |
| tokio | 18.6 KB | 18.4 KB | -0.2 KB |
| pgdog::frontend (other) | 9.6 KB | 9.6 KB | -0.1 KB |
| aws-lc (TLS crypto) | 8.8 KB | 8.6 KB | -0.1 KB |
| pgdog::backend::server | 8.2 KB | 8.0 KB | -0.2 KB |
| rustls (TLS) | 7.8 KB | 7.8 KB | +0.0 KB |
| other | 6.1 KB | 5.8 KB | -0.3 KB |
| everything else | 16.2 KB | 15.8 KB | -0.4 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.3 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.6 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.9 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.5 KB | -0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 28.8 KB | 28.8 KB | +0.1 KB |
| pgdog::frontend::client::query_engine | 23.8 KB | 23.7 KB | -0.1 KB |
| pgdog::backend::pool | 18.9 KB | 18.9 KB | -0.1 KB |
| tokio | 18.1 KB | 18.4 KB | +0.3 KB |
| other | 11.4 KB | 10.8 KB | -0.7 KB |
| pgdog::frontend (other) | 10.8 KB | 10.8 KB | +0.0 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.6 KB | +0.4 KB |
| pgdog::backend::server | 8.8 KB | 8.8 KB | -0.1 KB |
| everything else | 40.4 KB | 40.1 KB | -0.3 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.1 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.9 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.9 KB | +0.1 KB |
</details>
<details><summary>lb flamegraph vs 61e9a90b</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...).
</details>
<details><summary>microbench flamegraph vs 61e9a90b</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...).
</details>
<details><summary>pooler flamegraph vs 61e9a90b</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...).
</details>
<details><summary>sharding-w2 flamegraph vs 61e9a90b</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...).
</details>
<details><summary>sharding-w8 flamegraph vs 61e9a90b</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/jk-cross-shard-joins-core-v2/0b9dec694d88f5e8...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-cross-shard-join...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-cross-shard-join...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-cross-shard-join...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-cross-shard-join...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-cross-shard-join...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/jk-cross-shard-join...)
</details>
Compared 0b9dec69 with 61e9a90b on c7i.metal-48xl (on-demand).
view thread (4+ messages)
Message-ID: <gh-pgdogdev-pgdog-2070-c7010186114@github.com>
Permalink: ../gh-pgdogdev-pgdog-2070-c7010186114@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox