pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
[pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast
5+ messages / 4 participants
[nested] [flat]

* [pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast
@ 2026-11-19 12:54  "murex971 (@murex971)" <noreply+murex971@github.com>
  0 siblings, 0 replies; 5+ messages in thread

From: murex971 (@murex971) @ 2026-11-19 12:54 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

### Summary

A cross-shard `count(DISTINCT x)::int` returned the sum of each shard's
distinct count. The `DISTINCT` flag was only read when the aggregate was
the top-level expression, so a cast hid it and the query was merged as a
plain `count`.

The flag is now read from the same call node as the function name, after
unwrapping casts. These queries get the same `0A000` error as the uncast
form: "count(DISTINCT ...) is not yet supported".

The same applies to `sum`, `avg` and the variance functions.



inline patch 1: pgdog/src/frontend/client/query_engine/test/unsupported_aggregation.rs, pgdog/src/frontend/router/parser/aggregate.rs (+28/-11 lines) download inline-1.patchdiff --git a/pgdog/src/frontend/client/query_engine/test/unsupported_aggregation.rs b/pgdog/src/frontend/client/query_engine/test/unsupported_aggregation.rs index d8dcf4038..2a517aeff 100644 --- a/pgdog/src/frontend/client/query_engine/test/unsupported_aggregation.rs +++ b/pgdog/src/frontend/client/query_engine/test/unsupported_aggregation.rs @@ -18,6 +18,11 @@ async fn test_unsupported_aggregation_keeps_connection_usable() { "SELECT count(DISTINCT value) FROM sharded", "unsupported aggregation count: count(DISTINCT ...) is not yet supported", ), + ( + // The cast must not hide DISTINCT and let per-shard counts be summed. + "SELECT count(DISTINCT value)::int FROM sharded", + "unsupported aggregation count: count(DISTINCT ...) is not yet supported", + ), ( "SELECT count(*) FROM sharded HAVING count(*) > 0 LIMIT (SELECT 1)", "cross-shard HAVING is unsupported: \ diff --git a/pgdog/src/frontend/router/parser/aggregate.rs b/pgdog/src/frontend/router/parser/aggregate.rs index 4f10d2f54..730f2b24b 100644 --- a/pgdog/src/frontend/router/parser/aggregate.rs +++ b/pgdog/src/frontend/router/parser/aggregate.rs @@ -147,21 +147,19 @@ impl Aggregate { .iter() .enumerate() .filter_map(|(idx, node)| { - let func = Function::try_from(node.val()).ok()?; - let function = AggregateFunction::from_name(func.name, schema)?; - - // FIXME: This doesn't correctly handle distinct behind type - // casts any other nodes that Function::try_from handles - let distinct = if let Node::FuncCall(func) = node.val() { - func.agg_distinct - } else { - false - }; + // The call may sit behind a cast, e.g. `count(DISTINCT x)::int`. + let call = Function::extract_func_call(node.val())?; + let name = call + .funcname() + .iter() + .filter_map(Node::as_str) + .next_back()?; + let function = AggregateFunction::from_name(name, schema)?; Some(AggregateTarget { column: idx, function, - distinct, + distinct: call.agg_distinct, }) }) .collect(); @@ -269,6 +267,20 @@ mod test { assert!(!avg.is_distinct()); } + #[test] + fn test_parse_distinct_behind_cast() { + let aggr = parse( + "SELECT COUNT(DISTINCT price)::int, CAST(SUM(DISTINCT price) AS numeric)::text, \ + COUNT(price)::int FROM menu", + ); + let distinct = aggr + .targets() + .iter() + .map(AggregateTarget::is_distinct) + .collect::<Vec<_>>(); + assert_eq!(distinct, vec![true, true, false]); + } + #[test] fn test_parse_bool_and_bit_aggregates() { let aggr = parse(
^ permalink raw [nested|flat] 5+ messages in thread

* Re: [pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast
@ 2026-11-19 12:57  "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
  3 siblings, 0 replies; 5+ messages in thread

From: codecov[bot] (bot) (@codecov[bot]) @ 2026-11-19 12:57 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

## [Codecov](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2071?dropdown=coverage&src=pr&el=h1&utm_me...) Report
:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)

^ permalink  raw  [nested|flat] 5+ messages in thread

* Re: [pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast
@ 2026-11-19 13:37  "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  3 siblings, 0 replies; 5+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-19 13:37 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench -->

**Metal bench (arm64) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 19.03 (+0.8% ± 1.2%) | 17,798 (+0.0% ± 1.2%) | 31,452 (-0.0% ± 0.05%) | 30,941 (+1.2% ± 1.5%) | 51,125 (-0.1% ± 0.4%) |  |
| lb |  | 19.44 (-0.1% ± 1.2%) | 18,290 (-0.4% ± 0.8%) | 32,360 (+0.0% ± 0.02%) | 31,236 (-0.0% ± 2.0%) | 52,268 (+0.1% ± 0.3%) |  |
| sharding-w2 |  | 32.36 (-0.5% ± 3.1%) | 43,693 (-0.1% ± 2.5%) | 94,888 (-0.0% ± 0.00%) | 40,134 (-1.0% ± 2.1%) | 53,672 (+0.0% ± 0.05%) | 1.55 (+0.1% ± 0.4%) |
| sharding-w8 | 243,899 (-0.1% ± 0.3%) | 29.23 (+0.0% ± 0.3%) | 44,532 (+0.4% ± 2.4%) | 50,492 (+0.0% ± 0.2%) | 36,182 (-0.4% ± 2.1%) | 42,389 (-0.0% ± 0.08%) | 0.1699 (-0.1% ± 1.6%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,510 (-0.0% ± 3.1%) | 2,662 (+0.1% ± 1.1%) |  |
| lb | 7,742 (-1.1% ± 1.9%) | 2,696 (-0.3% ± 0.7%) |  |
| sharding-w2 | 18,126 (-0.2% ± 3.1%) | 4,168 (+0.1% ± 1.9%) |  |
| sharding-w8 | 20,409 (+1.8% ± 8.1%) | 4,170 (+0.8% ± 4.7%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 114.2 KB | 114.0 KB | **-0.2 KB** |
| sharding-w2 | 167.9 KB | 167.2 KB | **-0.8 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.2 KB | 20.1 KB | -0.1 KB |
| tokio | 18.5 KB | 18.4 KB | -0.1 KB |
| pgdog::backend::pool | 17.6 KB | 17.4 KB | -0.2 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.6 KB | +0.4 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 7.8 KB | 7.9 KB | +0.1 KB |
| pgdog::backend::server | 7.7 KB | 7.8 KB | +0.1 KB |
| other | 6.2 KB | 6.2 KB | -0.1 KB |
| everything else | 17.6 KB | 17.2 KB | -0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.6 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.1 KB | -0.2 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 28.7 KB | 29.0 KB | +0.3 KB |
| pgdog::frontend::client::query_engine | 21.6 KB | 21.4 KB | -0.2 KB |
| tokio | 18.2 KB | 18.9 KB | +0.6 KB |
| pgdog::backend::pool | 18.0 KB | 18.5 KB | +0.5 KB |
| aws-lc (TLS crypto) | 13.4 KB | 12.6 KB | -0.8 KB |
| other | 9.9 KB | 9.5 KB | -0.4 KB |
| pgdog::frontend (other) | 8.9 KB | 8.8 KB | -0.1 KB |
| rustls (TLS) | 8.1 KB | 8.1 KB | +0.1 KB |
| everything else | 41.2 KB | 40.4 KB | -0.8 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.3 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.3 KB | +0.1 KB |

</details>

<details><summary>lb flamegraph vs 14160e08</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...).
</details>
<details><summary>microbench flamegraph vs 14160e08</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...).
</details>
<details><summary>pooler flamegraph vs 14160e08</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...).
</details>
<details><summary>sharding-w2 flamegraph vs 14160e08</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...).
</details>
<details><summary>sharding-w8 flamegraph vs 14160e08</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/fix-unsupported-distinct/65f51c701389da0f3c5b1ecb...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/fix-unsupported-distinc...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/fix-unsupported-distinc...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/fix-unsupported-distinc...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/fix-unsupported-distinc...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/fix-unsupported-distinc...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/fix-unsupported-distinc...)
</details>

Compared 65f51c70 with 14160e08 on m8g.metal-24xl (spot).


^ permalink  raw  [nested|flat] 5+ messages in thread

* Re: [pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast
@ 2026-11-19 13:38  "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  3 siblings, 0 replies; 5+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-19 13:38 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 34.87 (-0.1% ± 0.3%) | 22,879 (-0.6% ± 0.7%) | 32,771 (+0.0% ± 0.02%) | 58,238 (-0.0% ± 0.3%) | 38,590 (+0.1% ± 0.10%) |  |
| lb |  | 35.9 (+0.0% ± 0.2%) | 24,109 (+0.0% ± 0.5%) | 33,727 (+0.0% ± 0.03%) | 59,179 (+0.0% ± 0.2%) | 39,224 (-0.0% ± 0.04%) |  |
| sharding-w2 |  | 56.9 (-0.2% ± 0.4%) | 53,511 (-0.0% ± 1.0%) | 98,639 (-0.0% ± 0.01%) | 73,787 (-0.3% ± 1.3%) | 43,036 (+0.0% ± 0.3%) | 1.388 (+0.1% ± 0.4%) |
| sharding-w8 | 148,060 (+0.6% ± 2.8%) | 48.31 (+0.2% ± 0.8%) | 58,034 (+0.4% ± 1.3%) | 54,111 (-0.1% ± 0.1%) | 64,623 (+0.1% ± 0.6%) | 34,229 (-0.1% ± 0.2%) | 0.1704 (-0.1% ± 2.6%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,371 (-0.3% ± 0.6%) | 3,677 (+0.0% ± 0.2%) |  |
| lb | 77,888 (+0.4% ± 1.0%) | 3,796 (+0.1% ± 0.1%) |  |
| sharding-w2 | 163,932 (-0.2% ± 0.9%) | 6,202 (-0.4% ± 0.3%) |  |
| sharding-w8 | 127,093 (+0.8% ± 1.9%) | 5,066 (-0.3% ± 0.6%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 8 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| simple_cold::insert | 6,042 ns | 6,286 ns | -3.88% ± 0.57% | +0.00% ± 0.00% |
| extended_cold::update_all_shards | 3,547 ns | 3,679 ns | -3.57% ± 1.53% | +0.00% ± 0.00% |
| extended_cold::update_by_key | 4,412 ns | 4,568 ns | -3.42% ± 0.14% | +0.00% ± 0.00% |
| simple_cold::select_all_shards | 3,831 ns | 3,963 ns | -3.32% ± 1.80% | -0.14% ± 0.00% |
| extended_cached::update_by_key | 2,422 ns | 2,504 ns | -3.27% ± 0.94% | +0.00% ± 0.00% |
| full_extended_cached::update_by_key | 13,048 ns | 13,482 ns | -3.22% ± 0.88% | +0.00% ± 0.00% |
| extended_cold::select_omni | 3,569 ns | 3,683 ns | -3.09% ± 0.51% | -0.08% ± 0.00% |
| extended_cold::lookup | 17,126 ns | 17,660 ns | -3.02% ± 0.39% | -0.03% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 110.4 KB | 113.8 KB | **+3.4 KB** |
| sharding-w2 | 169.3 KB | 169.5 KB | **+0.2 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 21.2 KB | 22.4 KB | +1.1 KB |
| tokio | 17.4 KB | 17.4 KB | +0.0 KB |
| pgdog::backend::pool | 16.6 KB | 16.8 KB | +0.2 KB |
| pgdog::frontend (other) | 9.2 KB | 9.4 KB | +0.2 KB |
| aws-lc (TLS crypto) | 6.8 KB | 7.8 KB | +1.0 KB |
| pgdog::backend::server | 7.0 KB | 7.4 KB | +0.4 KB |
| rustls (TLS) | 7.2 KB | 7.2 KB | +0.1 KB |
| jemalloc | 6.7 KB | 6.7 KB | +0.0 KB |
| everything else | 18.1 KB | 18.5 KB | +0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.2 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.8 KB | +0.4 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.8 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.7 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.6 KB | 27.3 KB | -0.2 KB |
| pgdog::frontend::client::query_engine | 22.9 KB | 23.2 KB | +0.3 KB |
| tokio | 18.4 KB | 18.6 KB | +0.2 KB |
| pgdog::backend::pool | 18.2 KB | 17.6 KB | -0.6 KB |
| other | 11.2 KB | 11.2 KB | +0.0 KB |
| pgdog::frontend (other) | 10.6 KB | 10.7 KB | +0.1 KB |
| aws-lc (TLS crypto) | 10.3 KB | 10.4 KB | +0.1 KB |
| jemalloc | 10.6 KB | 10.0 KB | -0.6 KB |
| everything else | 39.4 KB | 40.3 KB | +0.9 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.9 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | -0.2 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.1 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.8 KB | +0.0 KB |

</details>

<details><summary>lb flamegraph vs 14160e08</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>microbench flamegraph vs 14160e08</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>pooler flamegraph vs 14160e08</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>sharding-w2 flamegraph vs 14160e08</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>sharding-w8 flamegraph vs 14160e08</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...)
</details>

Compared 65f51c70 with 14160e08 on c7a.metal-48xl (spot).


^ permalink  raw  [nested|flat] 5+ messages in thread

* Re: [pgdogdev/pgdog] PR #2071 (approved): fix(cross-shard): detect DISTINCT on aggregates behind a cast
@ 2026-11-19 19:49  "levkk (@levkk)" <noreply+levkk@github.com>
  3 siblings, 0 replies; 5+ messages in thread

From: levkk (@levkk) @ 2026-11-19 19:49 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>



^ permalink  raw  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2026-11-19 19:49 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 12:54 [pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast "murex971 (@murex971)" <noreply+murex971@github.com>
2026-11-19 12:57 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
2026-11-19 13:37 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-19 13:38 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-19 19:49 ` Re: [pgdogdev/pgdog] PR #2071 (approved): fix(cross-shard): detect DISTINCT on aggregates behind a cast "levkk (@levkk)" <noreply+levkk@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox