pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2071: fix(cross-shard): detect DISTINCT on aggregates behind a cast
Date: Thu, 19 Nov 2026 13:38:09 +0000
Message-ID: <gh-pgdogdev-pgdog-2071-c7010756829@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2071@github.com>
References: <gh-pgdogdev-pgdog-2071@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 34.87 (-0.1% ± 0.3%) | 22,879 (-0.6% ± 0.7%) | 32,771 (+0.0% ± 0.02%) | 58,238 (-0.0% ± 0.3%) | 38,590 (+0.1% ± 0.10%) |  |
| lb |  | 35.9 (+0.0% ± 0.2%) | 24,109 (+0.0% ± 0.5%) | 33,727 (+0.0% ± 0.03%) | 59,179 (+0.0% ± 0.2%) | 39,224 (-0.0% ± 0.04%) |  |
| sharding-w2 |  | 56.9 (-0.2% ± 0.4%) | 53,511 (-0.0% ± 1.0%) | 98,639 (-0.0% ± 0.01%) | 73,787 (-0.3% ± 1.3%) | 43,036 (+0.0% ± 0.3%) | 1.388 (+0.1% ± 0.4%) |
| sharding-w8 | 148,060 (+0.6% ± 2.8%) | 48.31 (+0.2% ± 0.8%) | 58,034 (+0.4% ± 1.3%) | 54,111 (-0.1% ± 0.1%) | 64,623 (+0.1% ± 0.6%) | 34,229 (-0.1% ± 0.2%) | 0.1704 (-0.1% ± 2.6%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,371 (-0.3% ± 0.6%) | 3,677 (+0.0% ± 0.2%) |  |
| lb | 77,888 (+0.4% ± 1.0%) | 3,796 (+0.1% ± 0.1%) |  |
| sharding-w2 | 163,932 (-0.2% ± 0.9%) | 6,202 (-0.4% ± 0.3%) |  |
| sharding-w8 | 127,093 (+0.8% ± 1.9%) | 5,066 (-0.3% ± 0.6%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 8 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| simple_cold::insert | 6,042 ns | 6,286 ns | -3.88% ± 0.57% | +0.00% ± 0.00% |
| extended_cold::update_all_shards | 3,547 ns | 3,679 ns | -3.57% ± 1.53% | +0.00% ± 0.00% |
| extended_cold::update_by_key | 4,412 ns | 4,568 ns | -3.42% ± 0.14% | +0.00% ± 0.00% |
| simple_cold::select_all_shards | 3,831 ns | 3,963 ns | -3.32% ± 1.80% | -0.14% ± 0.00% |
| extended_cached::update_by_key | 2,422 ns | 2,504 ns | -3.27% ± 0.94% | +0.00% ± 0.00% |
| full_extended_cached::update_by_key | 13,048 ns | 13,482 ns | -3.22% ± 0.88% | +0.00% ± 0.00% |
| extended_cold::select_omni | 3,569 ns | 3,683 ns | -3.09% ± 0.51% | -0.08% ± 0.00% |
| extended_cold::lookup | 17,126 ns | 17,660 ns | -3.02% ± 0.39% | -0.03% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 110.4 KB | 113.8 KB | **+3.4 KB** |
| sharding-w2 | 169.3 KB | 169.5 KB | **+0.2 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 21.2 KB | 22.4 KB | +1.1 KB |
| tokio | 17.4 KB | 17.4 KB | +0.0 KB |
| pgdog::backend::pool | 16.6 KB | 16.8 KB | +0.2 KB |
| pgdog::frontend (other) | 9.2 KB | 9.4 KB | +0.2 KB |
| aws-lc (TLS crypto) | 6.8 KB | 7.8 KB | +1.0 KB |
| pgdog::backend::server | 7.0 KB | 7.4 KB | +0.4 KB |
| rustls (TLS) | 7.2 KB | 7.2 KB | +0.1 KB |
| jemalloc | 6.7 KB | 6.7 KB | +0.0 KB |
| everything else | 18.1 KB | 18.5 KB | +0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.2 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.8 KB | +0.4 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.8 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.7 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.6 KB | 27.3 KB | -0.2 KB |
| pgdog::frontend::client::query_engine | 22.9 KB | 23.2 KB | +0.3 KB |
| tokio | 18.4 KB | 18.6 KB | +0.2 KB |
| pgdog::backend::pool | 18.2 KB | 17.6 KB | -0.6 KB |
| other | 11.2 KB | 11.2 KB | +0.0 KB |
| pgdog::frontend (other) | 10.6 KB | 10.7 KB | +0.1 KB |
| aws-lc (TLS crypto) | 10.3 KB | 10.4 KB | +0.1 KB |
| jemalloc | 10.6 KB | 10.0 KB | -0.6 KB |
| everything else | 39.4 KB | 40.3 KB | +0.9 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.9 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | -0.2 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.1 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.8 KB | +0.0 KB |

</details>

<details><summary>lb flamegraph vs 14160e08</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>microbench flamegraph vs 14160e08</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>pooler flamegraph vs 14160e08</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>sharding-w2 flamegraph vs 14160e08</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>
<details><summary>sharding-w8 flamegraph vs 14160e08</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/fix-unsupported-distinct/65f51c701389da0f3c5b...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/fix-unsupported-dis...)
</details>

Compared 65f51c70 with 14160e08 on c7a.metal-48xl (spot).


view thread (5+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2071-c7010756829@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2071-c7010756829@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox