pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2072: refactor(cross-shard): sharding key lookup for aggregate rewrite
Date: Thu, 19 Nov 2026 14:03:54 +0000
Message-ID: <gh-pgdogdev-pgdog-2072-c7011370045@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2072@github.com>
References: <gh-pgdogdev-pgdog-2072@github.com>
<!-- metal-bench -->
**Metal bench (arm64) passed.** All 520 measures within bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 19.03 (+0.3% ± 1.2%) | 18,068 (-0.0% ± 0.8%) | 31,448 (-0.0% ± 0.04%) | 30,642 (+0.6% ± 2.1%) | 51,112 (+0.0% ± 0.4%) | |
| lb | | 19.59 (+0.5% ± 1.6%) | 18,653 (+0.2% ± 1.0%) | 32,348 (-0.0% ± 0.05%) | 31,300 (+1.1% ± 2.3%) | 52,228 (+0.2% ± 0.5%) | |
| sharding-w2 | | 32.28 (-0.2% ± 1.7%) | 43,386 (-0.2% ± 0.9%) | 94,901 (+0.0% ± 0.02%) | 40,460 (-0.2% ± 3.0%) | 53,742 (+0.1% ± 0.1%) | 1.547 (+0.1% ± 0.1%) |
| sharding-w8 | 243,532 (+0.5% ± 3.5%) | 29.43 (-0.3% ± 3.3%) | 44,253 (+0.1% ± 3.0%) | 50,494 (-0.0% ± 0.09%) | 37,021 (-0.8% ± 3.7%) | 42,373 (-0.0% ± 0.09%) | 0.166 (-1.0% ± 0.8%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,789 (+0.0% ± 2.1%) | 2,677 (-0.1% ± 0.9%) | |
| lb | 8,142 (+0.7% ± 2.4%) | 2,728 (+0.2% ± 1.1%) | |
| sharding-w2 | 17,981 (-0.3% ± 1.8%) | 4,167 (-0.2% ± 0.9%) | |
| sharding-w8 | 20,411 (+1.0% ± 5.0%) | 4,184 (+0.4% ± 2.5%) | |
</details>
Microbench: all 507 measures within bounds.
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 115.5 KB | 115.1 KB | **-0.4 KB** |
| sharding-w2 | 168.2 KB | 168.9 KB | **+0.7 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.4 KB | 20.2 KB | -0.1 KB |
| tokio | 18.6 KB | 18.6 KB | +0.0 KB |
| pgdog::backend::pool | 17.8 KB | 17.7 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.8 KB | 10.7 KB | -0.1 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.1 KB |
| pgdog::frontend (other) | 8.1 KB | 7.9 KB | -0.1 KB |
| pgdog::backend::server | 7.9 KB | 7.7 KB | -0.2 KB |
| other | 6.4 KB | 6.4 KB | +0.0 KB |
| everything else | 17.2 KB | 17.4 KB | +0.1 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.6 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | -0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.1 KB | 29.1 KB | -0.1 KB |
| pgdog::frontend::client::query_engine | 21.8 KB | 21.6 KB | -0.2 KB |
| tokio | 18.4 KB | 18.4 KB | +0.0 KB |
| pgdog::backend::pool | 18.1 KB | 18.4 KB | +0.2 KB |
| aws-lc (TLS crypto) | 13.0 KB | 13.2 KB | +0.2 KB |
| other | 10.1 KB | 10.4 KB | +0.2 KB |
| pgdog::frontend (other) | 8.8 KB | 8.9 KB | +0.1 KB |
| pgdog::backend::server | 8.0 KB | 8.2 KB | +0.2 KB |
| everything else | 40.8 KB | 40.8 KB | -0.1 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.3 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.4 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.3 KB | +0.0 KB |
</details>
<details><summary>lb flamegraph vs 65f51c70</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...).
</details>
<details><summary>microbench flamegraph vs 65f51c70</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...).
</details>
<details><summary>pooler flamegraph vs 65f51c70</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...).
</details>
<details><summary>sharding-w2 flamegraph vs 65f51c70</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...).
</details>
<details><summary>sharding-w8 flamegraph vs 65f51c70</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-agg-sharding-key-lookup/7bbe99ad12b066745db...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-agg-sharding-key-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-agg-sharding-key-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-agg-sharding-key-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-agg-sharding-key-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-agg-sharding-key-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-agg-sharding-key-...)
</details>
Compared 7bbe99ad with 65f51c70 on c8g.metal-24xl (on-demand).
view thread (5+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2072-c7011370045@github.com>
Permalink: ../gh-pgdogdev-pgdog-2072-c7011370045@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox