pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2072: refactor(cross-shard): sharding key lookup for aggregate rewrite
Date: Thu, 19 Nov 2026 14:06:03 +0000
Message-ID: <gh-pgdogdev-pgdog-2072-c7011422778@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2072@github.com>
References: <gh-pgdogdev-pgdog-2072@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 25.77 (-0.0% ± 0.3%) | 18,544 (+0.1% ± 0.2%) | 32,799 (-0.0% ± 0.04%) | 33,675 (-0.0% ± 0.3%) | 36,514 (-0.2% ± 0.3%) |  |
| lb |  | 26.18 (+0.1% ± 0.4%) | 19,093 (-0.1% ± 0.09%) | 33,779 (-0.0% ± 0.05%) | 33,808 (+0.1% ± 0.2%) | 37,316 (-0.1% ± 0.3%) |  |
| sharding-w2 |  | 42.4 (+0.2% ± 7.5%) | 47,936 (+0.4% ± 15.0%) | 98,725 (+0.0% ± 0.1%) | 38,787 (-0.2% ± 1.9%) | 40,061 (-0.0% ± 0.6%) | 1.517 (-0.0% ± 3.2%) |
| sharding-w8 | 206,253 (+0.1% ± 1.2%) | 32.97 (-0.2% ± 1.5%) | 45,983 (-0.4% ± 2.3%) | 53,048 (+0.0% ± 0.1%) | 31,396 (+0.0% ± 1.0%) | 32,506 (+0.0% ± 0.2%) | 0.173 (+0.4% ± 2.2%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 3,117 (-0.1% ± 0.6%) | 1,073 (-0.4% ± 0.8%) | 39,920 (+0.1% ± 0.5%) |
| lb | 3,280 (-0.5% ± 0.5%) | 1,110 (-0.4% ± 0.6%) | 40,667 (+0.2% ± 0.4%) |
| sharding-w2 | 8,234 (+23.4% ± 142.4%) | 1,636 (+1.6% ± 17.6%) | 107,641 (+0.8% ± 29.5%) |
| sharding-w8 | 3,355 (+0.4% ± 3.1%) | 890 (+0.5% ± 1.0%) | 178,158 (-0.7% ± 3.2%) |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 3 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| simple_cold::order_limit_offset | 8,998 ns | 8,668 ns | +3.80% ± 0.72% | +0.04% ± 0.00% |
| extended_evicting::having | 18,084 ns | 18,702 ns | -3.30% ± 0.72% | -0.00% ± 0.00% |
| extended_cold::having | 18,012 ns | 18,572 ns | -3.01% ± 0.94% | -0.00% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 117.6 KB | 115.6 KB | **-2.1 KB** |
| sharding-w2 | 174.4 KB | 168.3 KB | **-6.1 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 23.3 KB | 22.6 KB | -0.8 KB |
| pgdog::backend::pool | 18.6 KB | 18.4 KB | -0.2 KB |
| tokio | 18.5 KB | 18.4 KB | -0.1 KB |
| pgdog::frontend (other) | 9.8 KB | 9.8 KB | +0.0 KB |
| aws-lc (TLS crypto) | 8.6 KB | 8.4 KB | -0.2 KB |
| pgdog::backend::server | 8.1 KB | 7.9 KB | -0.1 KB |
| rustls (TLS) | 7.9 KB | 7.9 KB | -0.1 KB |
| other | 6.2 KB | 5.9 KB | -0.2 KB |
| everything else | 16.6 KB | 16.1 KB | -0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.4 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 5.0 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | +0.0 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 28.7 KB | 28.4 KB | -0.3 KB |
| pgdog::frontend::client::query_engine | 24.9 KB | 23.3 KB | -1.6 KB |
| pgdog::backend::pool | 19.6 KB | 18.9 KB | -0.8 KB |
| tokio | 18.8 KB | 18.7 KB | -0.1 KB |
| pgdog::frontend (other) | 11.1 KB | 10.7 KB | -0.4 KB |
| other | 11.0 KB | 10.2 KB | -0.8 KB |
| aws-lc (TLS crypto) | 10.2 KB | 10.1 KB | -0.1 KB |
| pgdog::backend::server | 9.1 KB | 8.8 KB | -0.3 KB |
| everything else | 41.2 KB | 39.2 KB | -1.9 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.5 KB | -0.4 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.2 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 4.0 KB | +0.0 KB |

</details>

<details><summary>lb flamegraph vs 65f51c70</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...).
</details>
<details><summary>microbench flamegraph vs 65f51c70</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...).
</details>
<details><summary>pooler flamegraph vs 65f51c70</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...).
</details>
<details><summary>sharding-w2 flamegraph vs 65f51c70</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...).
</details>
<details><summary>sharding-w8 flamegraph vs 65f51c70</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-agg-sharding-key-lookup/7bbe99ad12b0667...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-agg-sharding-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-agg-sharding-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-agg-sharding-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-agg-sharding-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-agg-sharding-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-agg-sharding-...)
</details>

Compared 7bbe99ad with 65f51c70 on c7i.metal-48xl (on-demand).


view thread (5+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2072-c7011422778@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2072-c7011422778@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox