pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
Date: Thu, 19 Nov 2026 14:20:50 +0000
Message-ID: <gh-pgdogdev-pgdog-2074-c7011799450@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2074@github.com>
References: <gh-pgdogdev-pgdog-2074@github.com>
<!-- metal-bench -->
**Metal bench (arm64) failed.** 5 of 520 measures outside bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | **19.67 (+2.2% ± 2.0%), bound +2%** | **18,366 (+2.7% ± 1.1%), bound +2%** | 31,404 (-0.0% ± 0.1%) | 32,091 (+2.6% ± 3.8%) | 50,777 (-0.2% ± 0.7%) | |
| lb | | **20.13 (+2.7% ± 1.4%), bound +2%** | **19,013 (+2.9% ± 1.3%), bound +2%** | 32,329 (+0.0% ± 0.04%) | 32,512 (+3.4% ± 2.0%) | 52,059 (-0.2% ± 0.3%) | |
| sharding-w2 | | 32.19 (+0.3% ± 1.6%) | 43,334 (+1.0% ± 1.3%) | 94,957 (+0.0% ± 0.05%) | 40,594 (-0.3% ± 2.8%) | 53,635 (-0.0% ± 0.2%) | 1.543 (-0.1% ± 0.04%) |
| sharding-w8 | 249,069 (-0.0% ± 2.4%) | 28.59 (-0.1% ± 2.2%) | 43,421 (+0.2% ± 2.6%) | 50,501 (-0.0% ± 0.05%) | 35,532 (-0.5% ± 2.2%) | 42,390 (+0.1% ± 0.2%) | 0.1732 (+1.0% ± 1.0%) |
- **pooler**: user cycles +2.7%, instructions flat. Unexplained.
- **lb**: user cycles +2.9%, instructions flat. Unexplained.
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 8,375 (+8.6% ± 3.6%) | 2,707 (+2.5% ± 1.6%) | |
| lb | 8,784 (+8.8% ± 3.5%) | 2,769 (+2.5% ± 1.6%) | |
| sharding-w2 | 18,518 (+2.9% ± 3.3%) | 4,216 (+1.2% ± 1.8%) | |
| sharding-w8 | 19,672 (+1.3% ± 5.4%) | 4,080 (+1.0% ± 2.9%) | |
</details>
| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| full_named_cached::having_distinct_limit | alloc_count | 535 | 527 | **+1.56% ± 1.30%** | +0% |
Microbench: 506 of 507 measures within bounds.
<details><summary>Microbench latency: 1 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::select_all_shards | 1,852 ns | 1,925 ns | -3.80% ± 0.36% | +0.00% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 114.7 KB | 114.8 KB | **+0.1 KB** |
| sharding-w2 | 168.8 KB | 167.8 KB | **-1.1 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.4 KB | 20.3 KB | -0.1 KB |
| tokio | 18.5 KB | 18.4 KB | -0.1 KB |
| pgdog::backend::pool | 17.7 KB | 17.6 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.5 KB | 10.5 KB | +0.0 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | +0.0 KB |
| pgdog::frontend (other) | 8.1 KB | 8.1 KB | +0.0 KB |
| pgdog::backend::server | 7.6 KB | 7.7 KB | +0.1 KB |
| other | 6.1 KB | 6.1 KB | +0.1 KB |
| everything else | 17.5 KB | 17.8 KB | +0.2 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.7 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | -0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.1 KB | 28.6 KB | -0.5 KB |
| pgdog::frontend::client::query_engine | 21.5 KB | 21.6 KB | +0.1 KB |
| tokio | 18.8 KB | 18.3 KB | -0.5 KB |
| pgdog::backend::pool | 18.1 KB | 18.2 KB | +0.2 KB |
| aws-lc (TLS crypto) | 12.9 KB | 12.6 KB | -0.4 KB |
| other | 10.2 KB | 10.0 KB | -0.2 KB |
| pgdog::frontend (other) | 8.8 KB | 8.8 KB | -0.1 KB |
| pgdog::backend::server | 8.0 KB | 8.4 KB | +0.4 KB |
| everything else | 41.4 KB | 41.3 KB | -0.1 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.8 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.3 KB | -0.1 KB |
</details>
<details><summary>lb flamegraph vs 6b0e24d7</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>microbench flamegraph vs 6b0e24d7</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>pooler flamegraph vs 6b0e24d7</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>sharding-w2 flamegraph vs 6b0e24d7</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>sharding-w8 flamegraph vs 6b0e24d7</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-chore--yko/e64189d8eb117e828c3...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-chor...)
</details>
Compared e64189d8 with 6b0e24d7 on m8g.metal-24xl (spot).
view thread (8+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2074-c7011799450@github.com>
Permalink: ../gh-pgdogdev-pgdog-2074-c7011799450@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox