pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2074: chore: remove unused dependencies
Date: Thu, 19 Nov 2026 14:21:25 +0000
Message-ID: <gh-pgdogdev-pgdog-2074-c7011815866@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2074@github.com>
References: <gh-pgdogdev-pgdog-2074@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) passed.** All 520 measures within bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 34.91 (+0.5% ± 0.3%) | 23,099 (+1.2% ± 0.5%) | 32,775 (-0.0% ± 0.02%) | 58,319 (+0.4% ± 0.5%) | 38,554 (-0.0% ± 0.3%) |  |
| lb |  | 35.94 (+0.4% ± 0.3%) | 24,261 (+1.0% ± 0.6%) | 33,736 (+0.0% ± 0.02%) | 59,351 (+0.3% ± 0.4%) | 39,200 (-0.0% ± 0.09%) |  |
| sharding-w2 |  | 56.57 (-0.0% ± 1.6%) | 53,512 (-0.1% ± 2.5%) | 98,693 (-0.0% ± 0.01%) | 73,426 (+0.1% ± 2.0%) | 43,110 (+0.0% ± 0.8%) | 1.391 (+0.2% ± 0.4%) |
| sharding-w8 | 146,409 (-0.5% ± 4.5%) | 48.68 (+0.6% ± 3.3%) | 57,910 (+0.5% ± 0.6%) | 54,239 (+0.1% ± 0.3%) | 65,745 (+0.8% ± 6.0%) | 34,259 (+0.1% ± 0.3%) | 0.1749 (+0.7% ± 6.3%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 74,749 (+2.4% ± 0.7%) | 3,707 (+1.0% ± 0.2%) |  |
| lb | 78,585 (+2.7% ± 1.5%) | 3,826 (+0.9% ± 0.2%) |  |
| sharding-w2 | 166,307 (+0.4% ± 6.1%) | 6,293 (-0.6% ± 1.5%) |  |
| sharding-w8 | 128,998 (+2.1% ± 1.4%) | 5,042 (-0.0% ± 0.5%) |  |
</details>

Microbench: all 507 measures within bounds.

<details><summary>Microbench latency: 19 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::delete_by_key | 2,184 ns | 2,299 ns | -5.00% ± 0.37% | +0.00% ± 0.00% |
| extended_cached::set | 1,441 ns | 1,513 ns | -4.76% ± 0.36% | +0.00% ± 0.00% |
| extended_cold::select_omni | 3,629 ns | 3,795 ns | -4.37% ± 0.86% | +0.00% ± 0.00% |
| extended_cold::select_all_shards | 4,003 ns | 4,174 ns | -4.09% ± 1.40% | +0.00% ± 0.00% |
| extended_cached::begin | 1,336 ns | 1,390 ns | -3.88% ± 0.78% | +0.00% ± 0.00% |
| extended_cold::select_by_key | 4,827 ns | 5,017 ns | -3.78% ± 0.53% | +0.00% ± 0.00% |
| extended_cached::delete_all_shards | 1,748 ns | 1,816 ns | -3.74% ± 0.72% | +0.00% ± 0.00% |
| extended_cached::select_omni | 2,024 ns | 2,102 ns | -3.71% ± 0.76% | +0.00% ± 0.00% |
| extended_cached::update_by_key | 2,368 ns | 2,456 ns | -3.58% ± 0.65% | +0.00% ± 0.00% |
| extended_cold::delete_all_shards | 2,939 ns | 3,047 ns | -3.54% ± 1.57% | +0.00% ± 0.00% |
| extended_cached::insert_returning | 2,324 ns | 2,406 ns | -3.42% ± 0.42% | +0.00% ± 0.00% |
| extended_cached::distinct | 2,376 ns | 2,460 ns | -3.41% ± 1.14% | +0.00% ± 0.00% |
| extended_cached::update_all_shards | 1,930 ns | 1,996 ns | -3.31% ± 0.55% | +0.00% ± 0.00% |
| extended_cold::insert | 6,237 ns | 6,445 ns | -3.22% ± 0.32% | +0.00% ± 0.00% |
| simple_cold::delete_all_shards | 2,841 ns | 2,931 ns | -3.07% ± 0.77% | +0.00% ± 0.00% |
| extended_cached::join | 3,856 ns | 3,978 ns | -3.06% ± 0.86% | +0.00% ± 0.00% |
| extended_cold::aggregate | 8,195 ns | 8,453 ns | -3.05% ± 0.65% | +0.00% ± 0.00% |
| extended_cached::having | 3,011 ns | 3,105 ns | -3.03% ± 0.72% | +0.00% ± 0.00% |
| extended_cold::select_in_list | 5,785 ns | 5,965 ns | -3.02% ± 0.49% | +0.00% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 107.9 KB | 110.8 KB | **+2.9 KB** |
| sharding-w2 | 167.4 KB | 169.0 KB | **+1.6 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.9 KB | 21.5 KB | +0.6 KB |
| tokio | 17.7 KB | 17.7 KB | +0.0 KB |
| pgdog::backend::pool | 16.3 KB | 16.6 KB | +0.3 KB |
| pgdog::frontend (other) | 9.3 KB | 9.5 KB | +0.2 KB |
| aws-lc (TLS crypto) | 6.6 KB | 7.7 KB | +1.1 KB |
| pgdog::backend::server | 7.1 KB | 7.2 KB | +0.1 KB |
| rustls (TLS) | 7.0 KB | 7.0 KB | +0.0 KB |
| jemalloc | 5.9 KB | 5.9 KB | +0.0 KB |
| everything else | 17.0 KB | 17.7 KB | +0.7 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.3 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.9 KB | +0.3 KB |
| `tokio::runtime::task::raw::poll` | 3.5 KB | +0.0 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.7 KB | 28.1 KB | +0.4 KB |
| pgdog::frontend::client::query_engine | 23.6 KB | 23.8 KB | +0.1 KB |
| pgdog::backend::pool | 17.8 KB | 18.1 KB | +0.4 KB |
| tokio | 18.1 KB | 17.5 KB | -0.6 KB |
| other | 10.5 KB | 10.8 KB | +0.2 KB |
| pgdog::frontend (other) | 10.8 KB | 10.7 KB | -0.1 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.5 KB | +0.4 KB |
| jemalloc | 9.9 KB | 10.5 KB | +0.6 KB |
| everything else | 39.1 KB | 39.1 KB | +0.1 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 8.1 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.7 KB | -0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.3 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 4.0 KB | -0.1 KB |

</details>

<details><summary>lb flamegraph vs 6b0e24d7</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>microbench flamegraph vs 6b0e24d7</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>pooler flamegraph vs 6b0e24d7</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>sharding-w2 flamegraph vs 6b0e24d7</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>
<details><summary>sharding-w8 flamegraph vs 6b0e24d7</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/meskill-2026-11-19-chore--yko/e64189d8eb117e8...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/meskill-2026-11-19-...)
</details>

Compared e64189d8 with 6b0e24d7 on c7a.metal-48xl (spot).


view thread (8+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2074-c7011815866@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2074-c7011815866@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox