pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2075: feat(lb): label replicas
Date: Thu, 19 Nov 2026 18:50:39 +0000
Message-ID: <gh-pgdogdev-pgdog-2075-c7018773289@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2075@github.com>
References: <gh-pgdogdev-pgdog-2075@github.com>
<!-- metal-bench -->
**Metal bench (arm64) failed.** 155 of 520 measures outside bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 19.15 (+0.8% ± 0.9%) | 18,223 (+0.4% ± 0.7%) | 31,478 (+0.3% ± 0.03%) | 30,705 (+1.3% ± 1.4%) | 50,992 (-0.0% ± 0.2%) | |
| lb | | 19.84 (+1.2% ± 1.1%) | 19,004 (+0.4% ± 0.6%) | **32,739 (+0.7% ± 0.08%), bound +0.5%** | 31,555 (+1.6% ± 2.0%) | 52,120 (-0.3% ± 0.2%) | |
| sharding-w2 | | 32.9 (+1.1% ± 0.5%) | 44,685 (+0.6% ± 0.9%) | 95,323 (+0.2% ± 0.01%) | 40,797 (+1.5% ± 2.0%) | 53,786 (+0.0% ± 0.7%) | 1.548 (-0.0% ± 0.4%) |
| sharding-w8 | 240,290 (-2.1% ± 1.1%) | 29.75 (+2.5% ± 1.2%) | 45,356 (+1.0% ± 1.9%) | 50,899 (+0.5% ± 0.04%) | 36,841 (+4.5% ± 1.9%) | 42,451 (-0.0% ± 0.1%) | 0.1667 (-2.5% ± 3.7%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 8,128 (+0.7% ± 1.5%) | 2,726 (+1.0% ± 0.5%) | |
| lb | 8,426 (-0.6% ± 0.9%) | 2,775 (+0.8% ± 0.4%) | |
| sharding-w2 | 19,258 (-0.0% ± 1.9%) | 4,380 (+0.5% ± 1.5%) | |
| sharding-w8 | 21,744 (+1.2% ± 5.8%) | 4,416 (+1.8% ± 3.8%) | |
</details>
| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::aggregate | alloc_bytes | 917 | 893 | **+2.69% ± 0.00%** | +1% |
| extended_cached::aggregate | instructions | 17,682 | 17,432 | **+1.43% ± 0.00%** | +1% |
| extended_cached::begin | alloc_bytes | 344 | 320 | **+7.50% ± 0.00%** | +1% |
| extended_cached::begin | instructions | 6,789 | 6,717 | **+1.07% ± 0.00%** | +1% |
| extended_cached::cte | alloc_bytes | 1,288 | 1,264 | **+1.90% ± 0.00%** | +1% |
| extended_cached::delete_all_shards | alloc_bytes | 408 | 384 | **+6.25% ± 0.00%** | +1% |
| extended_cached::delete_by_key | alloc_bytes | 612 | 588 | **+4.08% ± 0.00%** | +1% |
| extended_cached::distinct | alloc_bytes | 600 | 576 | **+4.17% ± 0.00%** | +1% |
| extended_cached::group_by | alloc_bytes | 968 | 944 | **+2.54% ± 0.00%** | +1% |
| extended_cached::having | alloc_bytes | 1,104 | 1,080 | **+2.22% ± 0.00%** | +1% |
| extended_cached::having_distinct_limit | alloc_bytes | 1,530 | 1,506 | **+1.59% ± 0.00%** | +1% |
| extended_cached::insert | alloc_bytes | 536 | 512 | **+4.69% ± 0.00%** | +1% |
| extended_cached::insert_returning | alloc_bytes | 536 | 512 | **+4.69% ± 0.00%** | +1% |
| extended_cached::insert_split | alloc_bytes | 7,386 | 7,026 | **+5.12% ± 0.00%** | +1% |
| extended_cached::insert_split | instructions | 41,496 | 41,019 | **+1.16% ± 0.00%** | +1% |
| extended_cached::join | alloc_bytes | 1,596 | 1,572 | **+1.53% ± 0.00%** | +1% |
| extended_cached::lookup | alloc_bytes | 912 | 888 | **+2.70% ± 0.00%** | +1% |
| extended_cached::min_max_sum | alloc_bytes | 880 | 856 | **+2.80% ± 0.00%** | +1% |
| extended_cached::order_limit_offset | alloc_bytes | 907 | 883 | **+2.72% ± 0.00%** | +1% |
| extended_cached::select_all_shards | alloc_bytes | 600 | 576 | **+4.17% ± 0.00%** | +1% |
| extended_cached::select_by_key | alloc_bytes | 912 | 888 | **+2.70% ± 0.00%** | +1% |
| extended_cached::select_in_list | alloc_bytes | 1,120 | 1,096 | **+2.19% ± 0.00%** | +1% |
| extended_cached::select_omni | alloc_bytes | 408 | 384 | **+6.25% ± 0.00%** | +1% |
| extended_cached::set | alloc_bytes | 401 | 377 | **+6.37% ± 0.00%** | +1% |
| extended_cached::subquery | alloc_bytes | 792 | 768 | **+3.12% ± 0.00%** | +1% |
| extended_cached::update_all_shards | alloc_bytes | 408 | 384 | **+6.25% ± 0.00%** | +1% |
| extended_cached::update_by_key | alloc_bytes | 612 | 588 | **+4.08% ± 0.00%** | +1% |
| extended_cold::aggregate | alloc_bytes | 1,990 | 1,966 | **+1.22% ± 0.00%** | +1% |
| extended_cold::begin | alloc_bytes | 782 | 758 | **+3.17% ± 0.00%** | +1% |
| extended_cold::cte | alloc_bytes | 1,839 | 1,815 | **+1.32% ± 0.00%** | +1% |
| extended_cold::delete_all_shards | alloc_bytes | 876 | 852 | **+2.82% ± 0.00%** | +1% |
| extended_cold::delete_by_key | alloc_bytes | 1,101 | 1,077 | **+2.23% ± 0.00%** | +1% |
| extended_cold::distinct | alloc_bytes | 1,099 | 1,075 | **+2.23% ± 0.00%** | +1% |
| extended_cold::group_by | alloc_bytes | 1,819 | 1,795 | **+1.34% ± 0.00%** | +1% |
| extended_cold::insert | alloc_bytes | 1,487 | 1,463 | **+1.64% ± 0.00%** | +1% |
| extended_cold::insert_returning | alloc_bytes | 1,529 | 1,505 | **+1.59% ± 0.00%** | +1% |
| extended_cold::insert_split | alloc_bytes | 9,722 | 9,362 | **+3.85% ± 0.00%** | +1% |
| extended_cold::join | alloc_bytes | 2,174 | 2,150 | **+1.12% ± 0.00%** | +1% |
| extended_cold::min_max_sum | alloc_bytes | 1,558 | 1,534 | **+1.56% ± 0.00%** | +1% |
| extended_cold::order_limit_offset | alloc_bytes | 1,523 | 1,499 | **+1.60% ± 0.00%** | +1% |
Microbench: 353 of 507 measures within bounds. See verdict.json for the rest.
<details><summary>Microbench latency: 18 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::insert | 1,846 ns | 1,760 ns | +4.92% ± 0.43% | +0.57% ± 0.00% |
| extended_evicting::begin | 1,928 ns | 1,841 ns | +4.68% ± 0.66% | +0.60% ± 0.00% |
| full_simple::order_limit_offset | 27,798 ns | 29,096 ns | -4.46% ± 0.84% | +0.14% ± 0.00% |
| full_named_cached::order_limit_offset | 28,216 ns | 29,456 ns | -4.19% ± 2.32% | -0.04% ± 0.00% |
| full_extended_cached::order_limit_offset | 29,006 ns | 30,198 ns | -3.95% ± 0.70% | +0.33% ± 0.00% |
| extended_cached::update_all_shards | 1,609 ns | 1,548 ns | +3.94% ± 0.37% | +0.67% ± 0.00% |
| extended_cached::having_distinct_limit | 2,809 ns | 2,703 ns | +3.93% ± 0.36% | +0.33% ± 0.00% |
| extended_cold::delete_all_shards | 2,432 ns | 2,341 ns | +3.88% ± 0.28% | +0.44% ± 0.00% |
| extended_cached::select_in_list | 2,649 ns | 2,551 ns | +3.84% ± 1.18% | +0.34% ± 0.00% |
| extended_cached::begin | 1,217 ns | 1,172 ns | +3.82% ± 0.41% | +1.07% ± 0.00% |
| extended_cached::order_limit_offset | 2,216 ns | 2,135 ns | +3.78% ± 0.88% | +0.47% ± 0.00% |
| extended_cached::insert_returning | 1,912 ns | 1,844 ns | +3.68% ± 0.50% | +0.53% ± 0.00% |
| extended_cached::delete_all_shards | 1,490 ns | 1,441 ns | +3.44% ± 0.58% | +0.78% ± 0.00% |
| extended_cached::select_omni | 1,741 ns | 1,685 ns | +3.29% ± 1.05% | +0.65% ± 0.00% |
| extended_cached::distinct | 1,983 ns | 1,921 ns | +3.26% ± 0.82% | +0.56% ± 0.00% |
| extended_cached::select_all_shards | 1,964 ns | 1,903 ns | +3.20% ± 0.84% | +0.58% ± 0.00% |
| extended_cached::min_max_sum | 2,573 ns | 2,494 ns | +3.16% ± 0.21% | +0.37% ± 0.00% |
| extended_cached::having | 2,468 ns | 2,395 ns | +3.07% ± 0.37% | +0.40% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 113.2 KB | 113.7 KB | **+0.4 KB** |
| sharding-w2 | 167.4 KB | 169.4 KB | **+1.9 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.1 KB | 20.8 KB | +0.7 KB |
| tokio | 18.4 KB | 18.6 KB | +0.2 KB |
| pgdog::backend::pool | 17.4 KB | 17.4 KB | +0.1 KB |
| aws-lc (TLS crypto) | 10.4 KB | 9.9 KB | -0.5 KB |
| rustls (TLS) | 8.3 KB | 8.4 KB | +0.1 KB |
| pgdog::frontend (other) | 7.8 KB | 7.9 KB | +0.1 KB |
| pgdog::backend::server | 7.7 KB | 7.8 KB | +0.1 KB |
| other | 6.2 KB | 5.8 KB | -0.4 KB |
| everything else | 17.0 KB | 17.2 KB | +0.2 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.6 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.6 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | +0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.1 KB | 30.1 KB | +0.9 KB |
| pgdog::frontend::client::query_engine | 21.7 KB | 21.7 KB | +0.0 KB |
| pgdog::backend::pool | 18.3 KB | 18.9 KB | +0.6 KB |
| tokio | 18.7 KB | 18.6 KB | -0.1 KB |
| aws-lc (TLS crypto) | 13.0 KB | 13.1 KB | +0.1 KB |
| other | 10.1 KB | 9.9 KB | -0.1 KB |
| pgdog::frontend (other) | 8.8 KB | 8.7 KB | -0.1 KB |
| pgdog::backend::server | 8.1 KB | 8.1 KB | +0.1 KB |
| everything else | 39.7 KB | 40.2 KB | +0.6 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.2 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | +0.1 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.8 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.4 KB | +0.1 KB |
</details>
<details><summary>lb flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...).
</details>
<details><summary>microbench flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...).
</details>
<details><summary>pooler flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...).
</details>
<details><summary>sharding-w2 flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...).
</details>
<details><summary>sharding-w8 flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/levkk-label-replicas/56897d2556d99049571b65f3f73c...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-label-replicas/56...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-label-replicas/56...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-label-replicas/56...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-label-replicas/56...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-label-replicas/56...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/levkk-label-replicas/56...)
</details>
Compared 56897d25 with dbeed6af on m8g.metal-24xl (spot).
view thread (17+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2075-c7018773289@github.com>
Permalink: ../gh-pgdogdev-pgdog-2075-c7018773289@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox