pg.ddx.io pgdogdev/pgdog GitHub issues and pull requests
help / color / mirror / Atom feedFrom: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2075: feat(lb): label replicas
Date: Thu, 19 Nov 2026 18:54:25 +0000
Message-ID: <gh-pgdogdev-pgdog-2075-c7018889922@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2075@github.com>
References: <gh-pgdogdev-pgdog-2075@github.com>
<!-- metal-bench-x86 -->
**Metal bench (x86) failed.** 152 of 520 measures outside bounds.
| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler | | 34.75 (+0.1% ± 0.2%) | 22,960 (-0.1% ± 0.8%) | 32,795 (+0.1% ± 0.02%) | 57,808 (+0.2% ± 0.2%) | 38,582 (-0.0% ± 0.2%) | |
| lb | | 35.86 (+0.1% ± 0.1%) | 24,536 (+0.9% ± 0.8%) | 34,106 (+0.5% ± 0.03%) | 58,576 (-0.3% ± 0.3%) | 39,194 (-0.1% ± 0.10%) | |
| sharding-w2 | | 56.59 (+0.6% ± 0.7%) | 53,543 (+0.9% ± 1.2%) | 98,957 (+0.2% ± 0.00%) | 72,750 (+0.6% ± 1.1%) | 43,096 (-0.0% ± 0.2%) | 1.39 (-0.2% ± 0.3%) |
| sharding-w8 | 147,459 (-1.3% ± 2.2%) | 48.43 (+0.7% ± 0.7%) | 58,829 (+1.7% ± 1.2%) | 54,419 (+0.3% ± 0.07%) | 64,149 (-0.0% ± 1.0%) | 34,204 (-0.0% ± 0.1%) | 0.1675 (-1.6% ± 2.8%) |
<details><summary>Counters per txn</summary>
| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 73,943 (-0.3% ± 0.8%) | 3,635 (+0.2% ± 0.2%) | |
| lb | 79,778 (+2.3% ± 0.7%) | 3,819 (+1.1% ± 0.3%) | |
| sharding-w2 | 163,694 (+1.8% ± 3.1%) | 6,134 (-0.3% ± 0.6%) | |
| sharding-w8 | 122,468 (-0.2% ± 4.5%) | 5,014 (+0.2% ± 0.6%) | |
</details>
| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::aggregate | alloc_bytes | 917 | 893 | **+2.69% ± 0.00%** | +1% |
| extended_cached::begin | alloc_bytes | 344 | 320 | **+7.50% ± 0.00%** | +1% |
| extended_cached::cte | alloc_bytes | 1,320 | 1,296 | **+1.85% ± 0.00%** | +1% |
| extended_cached::delete_all_shards | alloc_bytes | 408 | 384 | **+6.25% ± 0.00%** | +1% |
| extended_cached::delete_by_key | alloc_bytes | 620 | 596 | **+4.03% ± 0.00%** | +1% |
| extended_cached::distinct | alloc_bytes | 600 | 576 | **+4.17% ± 0.00%** | +1% |
| extended_cached::group_by | alloc_bytes | 968 | 944 | **+2.54% ± 0.00%** | +1% |
| extended_cached::having | alloc_bytes | 1,104 | 1,080 | **+2.22% ± 0.00%** | +1% |
| extended_cached::having_distinct_limit | alloc_bytes | 1,530 | 1,506 | **+1.59% ± 0.00%** | +1% |
| extended_cached::insert | alloc_bytes | 536 | 512 | **+4.69% ± 0.00%** | +1% |
| extended_cached::insert_returning | alloc_bytes | 536 | 512 | **+4.69% ± 0.00%** | +1% |
| extended_cached::insert_split | alloc_bytes | 7,386 | 7,026 | **+5.12% ± 0.00%** | +1% |
| extended_cached::join | alloc_bytes | 1,620 | 1,596 | **+1.50% ± 0.00%** | +1% |
| extended_cached::lookup | alloc_bytes | 928 | 904 | **+2.65% ± 0.00%** | +1% |
| extended_cached::min_max_sum | alloc_bytes | 880 | 856 | **+2.80% ± 0.00%** | +1% |
| extended_cached::order_limit_offset | alloc_bytes | 907 | 883 | **+2.72% ± 0.00%** | +1% |
| extended_cached::select_all_shards | alloc_bytes | 600 | 576 | **+4.17% ± 0.00%** | +1% |
| extended_cached::select_by_key | alloc_bytes | 928 | 904 | **+2.65% ± 0.00%** | +1% |
| extended_cached::select_in_list | alloc_bytes | 1,136 | 1,112 | **+2.16% ± 0.00%** | +1% |
| extended_cached::select_omni | alloc_bytes | 408 | 384 | **+6.25% ± 0.00%** | +1% |
| extended_cached::set | alloc_bytes | 401 | 377 | **+6.37% ± 0.00%** | +1% |
| extended_cached::subquery | alloc_bytes | 792 | 768 | **+3.12% ± 0.00%** | +1% |
| extended_cached::update_all_shards | alloc_bytes | 408 | 384 | **+6.25% ± 0.00%** | +1% |
| extended_cached::update_by_key | alloc_bytes | 620 | 596 | **+4.03% ± 0.00%** | +1% |
| extended_cold::aggregate | alloc_bytes | 1,990 | 1,966 | **+1.22% ± 0.00%** | +1% |
| extended_cold::begin | alloc_bytes | 782 | 758 | **+3.17% ± 0.00%** | +1% |
| extended_cold::cte | alloc_bytes | 1,871 | 1,847 | **+1.30% ± 0.00%** | +1% |
| extended_cold::delete_all_shards | alloc_bytes | 876 | 852 | **+2.82% ± 0.00%** | +1% |
| extended_cold::delete_by_key | alloc_bytes | 1,109 | 1,085 | **+2.21% ± 0.00%** | +1% |
| extended_cold::distinct | alloc_bytes | 1,099 | 1,075 | **+2.23% ± 0.00%** | +1% |
| extended_cold::group_by | alloc_bytes | 1,819 | 1,795 | **+1.34% ± 0.00%** | +1% |
| extended_cold::insert | alloc_bytes | 1,487 | 1,463 | **+1.64% ± 0.00%** | +1% |
| extended_cold::insert_returning | alloc_bytes | 1,529 | 1,505 | **+1.59% ± 0.00%** | +1% |
| extended_cold::insert_split | alloc_bytes | 9,722 | 9,362 | **+3.85% ± 0.00%** | +1% |
| extended_cold::join | alloc_bytes | 2,198 | 2,174 | **+1.10% ± 0.00%** | +1% |
| extended_cold::min_max_sum | alloc_bytes | 1,558 | 1,534 | **+1.56% ± 0.00%** | +1% |
| extended_cold::order_limit_offset | alloc_bytes | 1,523 | 1,499 | **+1.60% ± 0.00%** | +1% |
| extended_cold::select_all_shards | alloc_bytes | 1,070 | 1,046 | **+2.29% ± 0.00%** | +1% |
| extended_cold::select_by_key | alloc_bytes | 1,427 | 1,403 | **+1.71% ± 0.00%** | +1% |
| extended_cold::select_in_list | alloc_bytes | 1,652 | 1,628 | **+1.47% ± 0.00%** | +1% |
Microbench: 355 of 507 measures within bounds. See verdict.json for the rest.
<details><summary>Microbench latency: 21 benches changed more than 3%</summary>
| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cold::select_all_shards | 3,930 ns | 4,128 ns | -4.79% ± 0.66% | +0.22% ± 0.00% |
| extended_cold::update_by_key | 4,376 ns | 4,592 ns | -4.69% ± 2.18% | +0.15% ± 0.00% |
| extended_cold::distinct | 4,188 ns | 4,384 ns | -4.47% ± 0.68% | +0.18% ± 0.00% |
| simple_cold::begin | 1,879 ns | 1,966 ns | -4.43% ± 1.35% | +0.45% ± 0.00% |
| extended_cold::delete_by_key | 3,812 ns | 3,984 ns | -4.31% ± 0.70% | +0.18% ± 0.00% |
| extended_cold::begin | 1,981 ns | 2,069 ns | -4.25% ± 0.86% | +0.40% ± 0.00% |
| simple_cold::set | 2,406 ns | 2,506 ns | -3.99% ± 1.24% | -1.71% ± 0.00% |
| extended_evicting::set | 2,662 ns | 2,768 ns | -3.83% ± 0.84% | -1.51% ± 0.00% |
| simple_cold::update_by_key | 4,260 ns | 4,428 ns | -3.79% ± 1.08% | +0.16% ± 0.00% |
| extended_cold::select_by_key | 4,811 ns | 4,993 ns | -3.64% ± 1.09% | +0.15% ± 0.00% |
| simple_cold::select_all_shards | 3,807 ns | 3,951 ns | -3.64% ± 1.10% | +0.23% ± 0.00% |
| simple_cold::update_all_shards | 3,381 ns | 3,507 ns | -3.59% ± 0.63% | +0.21% ± 0.00% |
| extended_cold::delete_all_shards | 2,859 ns | 2,963 ns | -3.51% ± 0.37% | +0.26% ± 0.00% |
| extended_evicting::select_all_shards | 4,137 ns | 4,285 ns | -3.45% ± 1.00% | +0.19% ± 0.00% |
| simple_cold::delete_by_key | 3,696 ns | 3,828 ns | -3.44% ± 1.48% | +0.19% ± 0.00% |
| extended_evicting::update_all_shards | 3,647 ns | 3,777 ns | -3.44% ± 0.69% | +0.19% ± 0.00% |
| extended_evicting::begin | 2,145 ns | 2,221 ns | -3.42% ± 1.31% | +0.38% ± 0.00% |
| extended_cold::update_all_shards | 3,533 ns | 3,655 ns | -3.33% ± 1.06% | +0.20% ± 0.00% |
| extended_cold::select_omni | 3,573 ns | 3,689 ns | -3.14% ± 1.10% | +0.25% ± 0.00% |
| simple_cold::distinct | 4,109 ns | 4,239 ns | -3.07% ± 0.61% | +0.19% ± 0.00% |
| extended_evicting::distinct | 4,381 ns | 4,519 ns | -3.05% ± 0.87% | +0.17% ± 0.00% |
</details>
<details><summary>Hot code per txn</summary>
| path | base | head | change |
|---|---|---|---|
| pooler | 110.8 KB | 112.0 KB | **+1.2 KB** |
| sharding-w2 | 170.4 KB | 172.1 KB | **+1.8 KB** |
pooler:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 21.2 KB | 21.5 KB | +0.2 KB |
| tokio | 17.7 KB | 17.8 KB | +0.1 KB |
| pgdog::backend::pool | 16.6 KB | 16.8 KB | +0.2 KB |
| pgdog::frontend (other) | 9.2 KB | 8.9 KB | -0.2 KB |
| rustls (TLS) | 7.0 KB | 7.4 KB | +0.4 KB |
| pgdog::backend::server | 7.2 KB | 7.4 KB | +0.2 KB |
| aws-lc (TLS crypto) | 7.4 KB | 7.3 KB | -0.1 KB |
| jemalloc | 6.8 KB | 6.4 KB | -0.3 KB |
| everything else | 17.7 KB | 18.3 KB | +0.6 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.9 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.3 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.6 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.8 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.6 KB | +0.1 KB |
sharding-w2:
| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 27.2 KB | 28.2 KB | +0.9 KB |
| pgdog::frontend::client::query_engine | 23.4 KB | 23.9 KB | +0.4 KB |
| pgdog::backend::pool | 17.9 KB | 18.9 KB | +1.1 KB |
| tokio | 18.1 KB | 18.1 KB | -0.1 KB |
| other | 11.4 KB | 11.2 KB | -0.2 KB |
| jemalloc | 10.1 KB | 10.8 KB | +0.7 KB |
| pgdog::frontend (other) | 10.8 KB | 10.6 KB | -0.2 KB |
| aws-lc (TLS crypto) | 10.8 KB | 10.3 KB | -0.4 KB |
| everything else | 40.6 KB | 40.2 KB | -0.4 KB |
| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.9 KB | -0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.8 KB | +0.2 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.8 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.8 KB | +0.0 KB |
</details>
<details><summary>lb flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...).
</details>
<details><summary>microbench flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...).
</details>
<details><summary>pooler flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...).
</details>
<details><summary>sharding-w2 flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...).
</details>
<details><summary>sharding-w8 flamegraph vs dbeed6af</summary>

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...) for hover, zoom and search.

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/levkk-label-replicas/56897d2556d99049571b65f3...).
</details>
<details><summary>Logs</summary>
[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/levkk-label-replica...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/levkk-label-replica...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/levkk-label-replica...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/levkk-label-replica...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/levkk-label-replica...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/levkk-label-replica...)
</details>
Compared 56897d25 with dbeed6af on c7a.metal-48xl (spot).
view thread (17+ messages) latest in thread
Message-ID: <gh-pgdogdev-pgdog-2075-c7018889922@github.com>
Permalink: ../gh-pgdogdev-pgdog-2075-c7018889922@github.com/
·
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox