From: meskill (@meskill) <noreply+meskill@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2075: feat(lb): label replicas
Date: Fri, 20 Nov 2026 13:20:45 +0000
Message-ID: <gh-pgdogdev-pgdog-2075-rc4642919354@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2075-rc4642848334@github.com>
References: <gh-pgdogdev-pgdog-2075@github.com>
<gh-pgdogdev-pgdog-2075-rc4642848334@github.com>
(on pgdog/src/backend/pool/lb/mod.rs:461)
anyway, I'm worried about this approach of doing the fallback here, since any label misspell or config misconfiguration could show working queries instead of signaling of issues.
I faced the same controversy for the pgdog.role refactor - it sounds like the real cases may want different outcome (fail or use fallback) and not strict rule. I don't like very much that the routing can stop working as expected without visual signs