pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
From: github-actions[bot] (bot) (@github-actions[bot]) <noreply+github-actions[bot]@github.com>
To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>
Subject: Re: [pgdogdev/pgdog] PR #2077: fix(lb): bannable targets should not affect RR distribution
Date: Thu, 19 Nov 2026 20:14:00 +0000
Message-ID: <gh-pgdogdev-pgdog-2077-c7020991965@github.com> (raw)
In-Reply-To: <gh-pgdogdev-pgdog-2077@github.com>
References: <gh-pgdogdev-pgdog-2077@github.com>

<!-- metal-bench -->

**Metal bench (arm64) failed.** 5 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 19.63 (-0.7% ± 1.4%) | 19,361 (-0.4% ± 0.3%) | 31,417 (-0.1% ± 0.05%) | 31,237 (-0.8% ± 2.8%) | 51,035 (+0.2% ± 0.3%) |  |
| lb |  | 20.4 (+0.4% ± 0.9%) | 20,378 (+0.9% ± 0.6%) | **32,540 (+0.6% ± 0.03%), bound +0.5%** | 31,991 (+0.2% ± 1.9%) | 51,973 (-0.2% ± 0.4%) |  |
| sharding-w2 |  | 33.62 (+1.2% ± 1.6%) | 46,311 (+1.3% ± 2.0%) | 95,076 (+0.1% ± 0.00%) | 41,352 (+1.0% ± 2.9%) | 53,718 (-0.1% ± 0.5%) | 1.542 (-0.0% ± 0.1%) |
| sharding-w8 | 245,669 (+0.8% ± 1.0%) | 29.2 (-0.7% ± 0.8%) | 45,684 (+0.2% ± 1.5%) | 50,635 (+0.2% ± 0.01%) | 35,005 (-1.8% ± 1.5%) | 42,360 (-0.0% ± 0.2%) | 0.1673 (-0.3% ± 2.9%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 9,423 (-1.1% ± 0.8%) | 2,908 (-0.6% ± 0.5%) |  |
| lb | 10,166 (+1.1% ± 1.7%) | 3,006 (+0.1% ± 0.9%) |  |
| sharding-w2 | 20,882 (+2.4% ± 5.2%) | 4,594 (+1.8% ± 3.5%) |  |
| sharding-w8 | 21,558 (-0.6% ± 2.7%) | 4,366 (+0.4% ± 2.0%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::cte | instructions | 24,235 | 23,959 | **+1.15% ± 0.00%** | +1% |
| full_extended_cached::aggregate | instructions | 146,231 | 144,115 | **+1.47% ± 0.00%** | +1% |
| full_simple::order_limit_offset | instructions | 195,476 | 193,049 | **+1.26% ± 0.00%** | +1% |
| simple_cold::select_omni | instructions | 20,673 | 20,461 | **+1.04% ± 0.00%** | +1% |

Microbench: 503 of 507 measures within bounds.

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 114.2 KB | 113.8 KB | **-0.4 KB** |
| sharding-w2 | 168.1 KB | 168.8 KB | **+0.7 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.5 KB | 20.4 KB | -0.1 KB |
| tokio | 18.4 KB | 18.4 KB | +0.0 KB |
| pgdog::backend::pool | 17.5 KB | 17.5 KB | +0.0 KB |
| aws-lc (TLS crypto) | 10.1 KB | 10.2 KB | +0.1 KB |
| rustls (TLS) | 8.4 KB | 8.4 KB | -0.1 KB |
| pgdog::frontend (other) | 7.9 KB | 7.9 KB | -0.1 KB |
| pgdog::backend::server | 7.9 KB | 7.6 KB | -0.2 KB |
| other | 6.0 KB | 6.1 KB | +0.1 KB |
| everything else | 17.5 KB | 17.3 KB | -0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.6 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | -0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.1 KB | -0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.3 KB | 29.6 KB | +0.3 KB |
| pgdog::frontend::client::query_engine | 21.6 KB | 21.8 KB | +0.2 KB |
| tokio | 18.6 KB | 18.8 KB | +0.2 KB |
| pgdog::backend::pool | 18.0 KB | 18.6 KB | +0.6 KB |
| aws-lc (TLS crypto) | 12.7 KB | 12.8 KB | +0.1 KB |
| other | 10.0 KB | 9.7 KB | -0.3 KB |
| pgdog::frontend (other) | 8.9 KB | 8.9 KB | +0.0 KB |
| pgdog::backend::server | 8.1 KB | 8.2 KB | +0.1 KB |
| everything else | 41.1 KB | 40.5 KB | -0.6 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.2 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.0 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 3.9 KB | +0.0 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.1 KB |

</details>

<details><summary>lb flamegraph vs 61e9a90b</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...).
</details>
<details><summary>microbench flamegraph vs 61e9a90b</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...).
</details>
<details><summary>pooler flamegraph vs 61e9a90b</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...).
</details>
<details><summary>sharding-w2 flamegraph vs 61e9a90b</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...).
</details>
<details><summary>sharding-w8 flamegraph vs 61e9a90b</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/meskill-2026-11-19-fix-lb---vpm/50078d0312c940e13...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-fix-...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-fix-...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-fix-...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-fix-...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-fix-...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/meskill-2026-11-19-fix-...)
</details>

Compared 50078d03 with 61e9a90b on m8g.metal-24xl (spot).


view thread (7+ messages)  latest in thread

Message-ID: <gh-pgdogdev-pgdog-2077-c7020991965@github.com>
Permalink:  ../gh-pgdogdev-pgdog-2077-c7020991965@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox