pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: sehrope (@sehrope) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #2148: Avoid leaking server error details through BatchUpdateException when logServerErrorDetail=false
Date: Thu, 13 May 2021 16:48:47 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Nice looks like the push worked. Let's see it run through CI and then we'll merge it.

I split out your original fix into two commits. The first updates the docs. The second is the fix for the property handling with batches. The fix itself worked but was missing an update to the one other test class that also implements BaseConnection and there were a couple style issues.

Third commit adds some new tests with batching.

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #2148: Avoid leaking server error details through BatchUpdateException when logServerErrorDetail=false
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox