pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: sehrope (@sehrope) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
Date: Thu, 18 Apr 2024 13:29:33 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/DriverTest.java)
How about adding an overload for the old private `verifyUrl(...)` to call the new one?
```java
private void verifyUrl(Driver drv, String url, String hosts, String ports, String dbName) {
verifyUrl(drv, url, hosts, ports, dbName, "osUser", null);
}
```
That way the majority of the above test cases would not duplicate that info and it would better showcase that none of the expected behavior for those tests have changed.
view thread (55+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox