pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: MarekUniq (@MarekUniq) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
Date: Fri, 07 Jun 2024 06:35:56 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
(on pgjdbc/src/main/java/org/postgresql/PGEnvironment.java)
The "old" default value is incorrect for all major operating systems: Linux, Windows, and MacOS.
A bit more correct value would be: `.pg_service.conf`
Correct value would be: `${HOME}/.pg_service.conf` for Linux/MacOS and `%APPDATA%\postgresql\.pg_service.conf` for Windows
I disagree that maintaining this incorrect default value is necessary, but since it seems to be a blocking issue, I have reverted code to keep the incorrect "old" default value.
Additionally, I have marked the `getDefaultValue()` function as deprecated.
This serves as a reminder that in the next major version, both the function and the incorrect default value may be removed from the code.
view thread (55+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox