pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  
help / color / mirror / Atom feed
From: jrobe (@jrobe) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #2923: un-deprecate SSL_FACTORY_ARG
Date: Thu, 29 Jun 2023 16:00:28 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> If we add properties constructor, people might start using it, and it would be easier for them to configure, document, and understand.
> 
> For instance, `SingleCertValidatingFactory.tlsCertificate` property name would be much easier to find and understand in the documentation, internal wikis, emails, and StackOverflow than an obscure sslfactoryarg.

It's strange to me that the solution to the problem is "add another property" instead of support the existing one. Especially when the initial argument for marking it as deprecated was "there are too many properties" https://github.com/pgjdbc/pgjdbc/issues/1293

view thread (26+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #2923: un-deprecate SSL_FACTORY_ARG
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox