pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3141: Speed up getDate by parsing bytes instead of String
Date: Fri, 24 Jan 2025 08:06:47 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

(on pgjdbc/src/main/java/org/postgresql/jdbc/ArrayDecoding.java:339)

I'm afraid I don't understand how this was supposed to improve the performance.
It seems extremely misleading to pass `byte[]`. Initially I thought it was supposed to be a `postgresql binary encoded value`, however, in practice it the method expects a sting in a format of `byte[]`.

Adding `.getBytes()` all over the place does not make life easier as well :-/

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3141: Speed up getDate by parsing bytes instead of String
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox