pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: davecramer (@davecramer) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
Date: Sat, 27 Apr 2024 18:06:53 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
(on .github/workflows/main.yml:101)
> Ah that's interesting. So this would be testing some JDK running on Windows vs a Linux Postgres running in Docker?
>
> If we're going to test against Windows (i.e. duplicate what's in AppVeyor), could have a separate branch for the server itself running on Windows. The GitHub Runner installed software list for "windows-2022" says that it already has PostgreSQL 14.x installed: https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#databases
>
> I think we'd be kind of tied to whatever they include in the runner image, but that's not any worse than what we have in AppVeyor. With the advantage that it'd work for forks too.
Yeah, well ideally we want to be able to test windows with different PostgreSQL versions. If we just want v14 then we can use whatever is there
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3232: add windows-latest as it supports docker
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox