pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: kimjand (@kimjand) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3369: fix: EOFException on PreparedStatement#toString with unset bytea parameter since 42.7.4
Date: Thu, 20 Mar 2025 15:45:55 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On 20-03-2025 14:32, Rico Neubauer wrote:
>             Could you keep the old method names and signatures?
> 
>         @kimjand <https://github.com/kimjand; added a method, that
>         differs from existing one (see javadoc), not sure what you @vlsi
>         <https://github.com/vlsi; mean with keeping the old names?
> 
>     Instead of using toStringLiteral() use toString()
> 
>  From javadoc, I'd assume this was on purpose. @kimjand <https:// 
> github.com/kimjand> could you comment on this?
> 

Yes, this was completely intentional. The core of this bug is that the 
driver can't decide on what the methods are supposed to do. ToString 
claims it provides human readable output, but the driver expects it to 
contain literals for the parameter values.
Now there is a clear distinction between the two cases.

view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3369: fix: EOFException on PreparedStatement#toString with unset bytea parameter since 42.7.4
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox