pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: crowmagnumb (@crowmagnumb) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
Date: Fri, 10 Jan 2025 23:02:33 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> It also seems to me that if (type == Byte.class ) there is not enough primitive type checking, which is available for all types except byte. Something like this:
> 
> ```
>     if (type == Byte.class || type == byte.class) {
>       return (SQLFunction<String, T>) byteConv;
>     }
> ```
> 
> In the getConverter. We are checking Array. Should we also check SQLXML there?
> 
> p.s I'm sorry for writing this here. I'm just very interested in the functionality that you've implemented.

I just added these. cheers.

view thread (67+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3396: SQLData Support
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox