pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds 8+ messages / 4 participants [nested] [flat]
* [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-14 23:08 "devrimgunduz (@devrimgunduz)" <[email protected]> 0 siblings, 0 replies; 8+ messages in thread From: devrimgunduz (@devrimgunduz) @ 2025-01-14 23:08 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Hi, RHEL 8 builds are broken with the 42.7.5 because of the mininum maven requirement: `[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.6.0:shade (default) on project postgresql: The plugin org.apache.maven.plugins:maven-shade-plugin:3.6.0 requires Maven version 3.6.3 -> [Help 1] ` RHEL 8 is still widely used and it ships with maven 3.5.4. Any chance to relax this dependency? Thanks! Regards, Devrim ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 11:07 ` "davecramer (@davecramer)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: davecramer (@davecramer) @ 2025-01-15 11:07 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @jorsol can we accomodate this request ? https://github.com/pgjdbc/pgjdbc/commit/f2f3d68cddbae5aaafcb1681787f62d3ae61def7#diff-b309a59a5808c3... @devrimgunduz can you just change the version of the shade plugin when you build ? ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 12:17 ` "jorsol (@jorsol)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: jorsol (@jorsol) @ 2025-01-15 12:17 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Yes, it could be downgraded to `3.5.1`, this could also be done when building the rpm package, the red hat folks even removed the plugin since they don't allow shaded dependencies: https://src.fedoraproject.org/rpms/postgresql-jdbc/blob/rawhide/f/postgresql-jdbc.spec#_98 A similar approach can be done on the spec used of PGDG, by simply downgrading the version to 3.5.1 of the shade plugin and it should build on Maven 3.5.4. ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 12:20 ` "davecramer (@davecramer)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: davecramer (@davecramer) @ 2025-01-15 12:20 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @devrimgunduz I feel like we should have a test for your builds in our CI pipeline ? ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 12:26 ` "vlsi (@vlsi)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: vlsi (@vlsi) @ 2025-01-15 12:26 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> It seems like the recent release builds with Copr somehow: * https://github.com/pgjdbc/pgjdbc/actions/runs/12775033160/job/35610465749 * https://copr.fedorainfracloud.org/coprs/g/pgjdbc/pgjdbc/build/8513341/ * https://download.copr.fedorainfracloud.org/results/@pgjdbc/pgjdbc/fedora-rawhide-x86_64/08513341-pos... => `+ /usr/bin/python3 /usr/share/java-utils/pom_editor.py pom_xpath_remove 'pom:plugin[pom:artifactId = '\''maven-shade-plugin'\'']'` See https://github.com/pgjdbc/pgjdbc/blob/032d0e225a91e866d7dae680ebb784507392e803/packaging/rpm/postgre... In other words, for rpm-like builds we expect to remove shading plugin altogether. However, the released `pom.xml` can produce both shaded and non-shaded dependencies. So you could either cut out `maven-shade-plugin` (see `postgresql-jdbc.spec.tpl`) or use `mvn -DskipShadeDependencies=true ....` to avoid shading altogether (see https://github.com/pgjdbc/pgjdbc/blob/032d0e225a91e866d7dae680ebb784507392e803/pgjdbc/reduced-pom.xm...) ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 16:40 ` "devrimgunduz (@devrimgunduz)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: devrimgunduz (@devrimgunduz) @ 2025-01-15 16:40 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Really appreciated! Removed that plugin and builds work fine. Thanks. ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 17:02 ` "jorsol (@jorsol)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: jorsol (@jorsol) @ 2025-01-15 17:02 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @devrimgunduz keep in mind that if you don't shade the dependencies, you also need to package the dependencies used for scram authentication, or there will be lots of complains that scram authentication does not work. So you can remove the plugin and package the scram/stringprep dependencies, or just simply downgrade the version to 3.5.1 and keep using the shaded version. ^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds @ 2025-01-15 18:08 ` "devrimgunduz (@devrimgunduz)" <[email protected]> 6 siblings, 0 replies; 8+ messages in thread From: devrimgunduz (@devrimgunduz) @ 2025-01-15 18:08 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Thank you! Pushed the driver with downgrading shade plugin to 3.5.1 ^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2025-01-15 18:08 UTC | newest] Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-14 23:08 [pgjdbc/pgjdbc] issue #3480: 42.7.5 breaks RHEL 8 builds "devrimgunduz (@devrimgunduz)" <[email protected]> 2025-01-15 11:07 ` "davecramer (@davecramer)" <[email protected]> 2025-01-15 12:17 ` "jorsol (@jorsol)" <[email protected]> 2025-01-15 12:20 ` "davecramer (@davecramer)" <[email protected]> 2025-01-15 12:26 ` "vlsi (@vlsi)" <[email protected]> 2025-01-15 16:40 ` "devrimgunduz (@devrimgunduz)" <[email protected]> 2025-01-15 17:02 ` "jorsol (@jorsol)" <[email protected]> 2025-01-15 18:08 ` "devrimgunduz (@devrimgunduz)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox