pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
4+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
@ 2025-01-22 00:52  "ecki (@ecki)" <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: ecki (@ecki) @ 2025-01-22 00:52 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

This code sends extra_float_digits=2 for older than 9 and newer than 12. 

https://github.com/pgjdbc/pgjdbc/blob/032d0e225a91e866d7dae680ebb784507392e803/pgjdbc/src/main/java/...

It probably doesnt matter for newer Servers if 2 or 3, but the comment in the code does not explain this case.

Either remove the <12 condition so it sends 3 for all neuer Servers or explain in the else „also send value 2 for newer servers (since 12 any value bigger than 0 will enable the shortest precise decimal mode).“

I would and a comment clarifying the meaning of 3 for older servers and >0 for newer ones anyway as there to explain the hardcoded values 2 and 3.

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
@ 2025-01-22 01:23  "davecramer (@davecramer)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2025-01-22 01:23 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Good catch, thanks!

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
@ 2025-01-22 07:07  "davecramer (@davecramer)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2025-01-22 07:07 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

fixed in PR #3491 

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits
@ 2025-02-02 19:07  "ecki (@ecki)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: ecki (@ecki) @ 2025-02-02 19:07 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Thanks

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2025-02-02 19:07 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-01-22 00:52 [pgjdbc/pgjdbc] issue #3490: Clarify startup parameter selection since Version 12 for extra_float_digits "ecki (@ecki)" <[email protected]>
2025-01-22 01:23 ` "davecramer (@davecramer)" <[email protected]>
2025-01-22 07:07 ` "davecramer (@davecramer)" <[email protected]>
2025-02-02 19:07 ` "ecki (@ecki)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox