pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
Date: Fri, 24 Jan 2025 14:53:48 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

> it will clean up a lot of things.

Just for the reference, ErrorProne does not fix issues. It only reports them and suggests fixes.

For example:

```
> Task :postgresql:compileJava
pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java:1741: Note: [MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
  private void checkPermission(SQLPermission sqlPermissionNetworkTimeout) {
  ^
    (see https://errorprone.info/bugpattern/MethodCanBeStatic)
  Did you mean 'private static void checkPermission(SQLPermission sqlPermissionNetworkTimeout) {'?
```

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox