pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property
4+ messages / 3 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property
@ 2025-02-06 11:08  "raminorujov (@raminorujov)" <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: raminorujov (@raminorujov) @ 2025-02-06 11:08 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Implemented the feature suggestion in [#3467](https://github.com/pgjdbc/pgjdbc/issues/3467)
Enhanced DatabaseMetadata, added index comment as REMARKS property

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?

<!-- You can erase any parts of this template not applicable to your Pull Request. -->

### New Feature Submissions:

1. [ ] Does your submission pass tests?
2. [x] Does `./gradlew styleCheck` pass ?
3. [x] Have you added your new test classes to an existing test suite in alphabetical order?

### Changes to Existing Features:

* [ ] Does this break existing behaviour? If so please explain.
* [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
* [ ] Have you written new tests for your core changes, as applicable?
* [ ] Have you successfully run tests with your changes locally?


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property
@ 2025-02-06 11:11  "raminorujov (@raminorujov)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: raminorujov (@raminorujov) @ 2025-02-06 11:11 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Build fails on Windows with error `Could not find a part of the path 'C:\Program Files\PostgreSQL\9.6\data\postgresql.conf'`, which is not related to my change.

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property
@ 2025-02-06 11:32  "davecramer (@davecramer)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2025-02-06 11:32 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

FYI
 DatabaseMetaData::getIndexInfo() and this method (and some others) has not included the REMARKS column since JDBC 1.0.2

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property
@ 2025-02-06 12:43  "vlsi (@vlsi)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: vlsi (@vlsi) @ 2025-02-06 12:43 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

The rest of the methods like `getTables`, `getColumns` include `REMARKS`, so I think the miss of `REMARKS` in `getIndexInfo` is unintentional.

At the same time, adding vendor's columns is allowed:

> Additional columns beyond the columns defined to be returned by the ResultSet object for a given method can be defined by the JDBC driver vendor and must be accessed by their column label.


^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2025-02-06 12:43 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-02-06 11:08 [pgjdbc/pgjdbc] PR #3513: feat: enhanced DatabaseMetadata.getIndexInfo() method, added index comment as REMARKS property "raminorujov (@raminorujov)" <[email protected]>
2025-02-06 11:11 ` "raminorujov (@raminorujov)" <[email protected]>
2025-02-06 11:32 ` "davecramer (@davecramer)" <[email protected]>
2025-02-06 12:43 ` "vlsi (@vlsi)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox