pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
5+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
@ 2025-03-08 11:36  "davecramer (@davecramer)" <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2025-03-08 11:36 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
@ 2025-03-09 08:33  "vlsi (@vlsi)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: vlsi (@vlsi) @ 2025-03-09 08:33 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

What is the intention of the change?

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
@ 2025-03-09 10:40  "davecramer (@davecramer)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2025-03-09 10:40 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Well we had `upperCaseFieldLabels` in there at one point and never used it for all the functions. I just find the code easier to read without \" There should be no change other than that.

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
@ 2025-03-09 10:56  "vlsi (@vlsi)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: vlsi (@vlsi) @ 2025-03-09 10:56 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Even though we might have a function that forces all the column names go uppercase, it seems wasteful to force the conversion every time as we could just spell the columns so they go uppercase in the first place.

In other words, I'm fine to keep `upperCaseFieldLabels` call. However, it looks we could make the driver more efficient if we keep the quotes so the columns go upper case on their own, and we do not spent time in `upperCaseFieldLabels`

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead
@ 2025-03-09 10:59  "davecramer (@davecramer)" <[email protected]>
  3 siblings, 0 replies; 5+ messages in thread

From: davecramer (@davecramer) @ 2025-03-09 10:59 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Hard to argue with that. I'm not committed to the PR. It does nothing other than make things nice to read. If we don't use the function then we should get rid of it

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

end of thread, other threads:[~2025-03-09 10:59 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-08 11:36 [pgjdbc/pgjdbc] PR #3561: remove forcing uppercase and use the function upperCaseFieldLabels instead "davecramer (@davecramer)" <[email protected]>
2025-03-09 08:33 ` "vlsi (@vlsi)" <[email protected]>
2025-03-09 10:40 ` "davecramer (@davecramer)" <[email protected]>
2025-03-09 10:56 ` "vlsi (@vlsi)" <[email protected]>
2025-03-09 10:59 ` "davecramer (@davecramer)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox