pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3652: chore: update JUnit to 5.13, use @ParameterizedClass
Date: Mon, 02 Jun 2025 07:34:04 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
The procedure was like
* remove `import org.junit.Test;`
* autofix "import `@Test`" with junit5
* autofix "JUnit4 assertions used in JUnit5 test"
* make all Assertion imports static
* wrap long assertion lines if needed <-- this was manual
* replace `@RunWith(Parameterized.class)` with `@ParameterizedClass`, add `@MethodSource("data")`
My guess is that with an LLM I would not have any confidence in the result: JUnit4 and JUnit5 have different order of arguments for `assertEquals`, and sometimes the code was using the wrong order.
As I migrated the code I did not bother understanding the diffs as long as it compiled.
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3652: chore: update JUnit to 5.13, use @ParameterizedClass
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox