pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
7+ messages / 2 participants
[nested] [flat]
* [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-06-30 10:19 "davecramer (@davecramer)" <[email protected]>
0 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2025-06-30 10:19 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-06-30 11:24 "vlsi (@vlsi)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: vlsi (@vlsi) @ 2025-06-30 11:24 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
Can we somehow test this?
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-06-30 11:26 "davecramer (@davecramer)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2025-06-30 11:26 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
> Can we somehow test this?
we have the debezium test, although I'm not sure this is tested.
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-07-03 07:06 "vlsi (@vlsi)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: vlsi (@vlsi) @ 2025-07-03 07:06 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/core/v3/replication/V3PGReplicationStream.java:222)
How do we test that the order of the arguments here is right? Would any test fail if the code was like `between(now, POSTGRES_EPOCH_2000_01_01);` ?
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-07-03 15:41 "davecramer (@davecramer)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2025-07-03 15:41 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/core/v3/replication/V3PGReplicationStream.java:222)
according to the docs of Duration.between() `The result of this method can be a negative period if the end is before the start. To guarantee to obtain a positive duration call abs() on the result.` So we could do that?
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-07-03 15:47 "vlsi (@vlsi)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: vlsi (@vlsi) @ 2025-07-03 15:47 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/core/v3/replication/V3PGReplicationStream.java:222)
No no no. I do not suggest adding abs. I just mean that it is often the case for a `+` vs `-` or `between(POSTGRES_EPOCH_2000_01_01, now)` vs `between(now, POSTGRES_EPOCH_2000_01_01)` errors. Sure one of them is right, and I just wonder how can we be sure the code is right here.
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime
@ 2025-07-07 15:01 "davecramer (@davecramer)" <[email protected]>
5 siblings, 0 replies; 7+ messages in thread
From: davecramer (@davecramer) @ 2025-07-07 15:01 UTC (permalink / raw)
To: pgjdbc/pgjdbc <[email protected]>
(on pgjdbc/src/main/java/org/postgresql/core/v3/replication/V3PGReplicationStream.java:222)
fixed
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-07-07 15:01 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-06-30 10:19 [pgjdbc/pgjdbc] PR #3698: fix: updateStatus message to microseconds since midnight 01-01-1970 instead of using nanotime "davecramer (@davecramer)" <[email protected]>
2025-06-30 11:24 ` "vlsi (@vlsi)" <[email protected]>
2025-06-30 11:26 ` "davecramer (@davecramer)" <[email protected]>
2025-07-03 07:06 ` "vlsi (@vlsi)" <[email protected]>
2025-07-03 15:41 ` "davecramer (@davecramer)" <[email protected]>
2025-07-03 15:47 ` "vlsi (@vlsi)" <[email protected]>
2025-07-07 15:01 ` "davecramer (@davecramer)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox