pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3705: feat: default query timeout property
Date: Tue, 12 Aug 2025 07:58:33 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
I've made a second review pass, and I wondered whether we should support millisecond resolution for the default query timeout or second resolution.
JDBC supports second-resolution only via `java.sql.Statement#setQueryTimeout(int seconds)`.
At the same time, `java.sql.Connection#setNetworkTimeout(Executor, int millis)` uses millis.
pgjdbc has `org.postgresql.jdbc.PgStatement#setQueryTimeoutMs(long millis)` which uses millis.
However, the existing `loginTimeout`, `connectTimeout`, `socketTimeout`, and `cancelSignalTimeout` connection properties use seconds. So it sounds fine to use seconds unit for the newly added `defaultQueryTimeout` property.
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3705: feat: default query timeout property
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox