pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation 9+ messages / 4 participants [nested] [flat]
* [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-07-29 14:38 "eitch (@eitch)" <[email protected]> 0 siblings, 0 replies; 9+ messages in thread From: eitch (@eitch) @ 2025-07-29 14:38 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> ### All Submissions: * [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document? * [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change? Simple fix for allowing to use a custom PGXmlFactoryFactory ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-07-29 18:02 ` "davecramer (@davecramer)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: davecramer (@davecramer) @ 2025-07-29 18:02 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> it would be useful to add a test which just tries to load the default like you did in your issue ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-07-30 06:22 ` "eitch (@eitch)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: eitch (@eitch) @ 2025-07-30 06:22 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Yeah, sorry, that was why this was still a draft. I had to find time to figure out the building and everything. It wasn't straightforward to get it to work in IntelliJ. And it doesn't build with Java 24... Added a test now, looks fine to me. ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-07-31 06:05 ` "eitch (@eitch)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: eitch (@eitch) @ 2025-07-31 06:05 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @davecramer Why did the code style check fail? I can't see any issues with the import statements. ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-07-31 08:39 ` "vlsi (@vlsi)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: vlsi (@vlsi) @ 2025-07-31 08:39 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> @eitch , the job log lists the deviations: https://github.com/pgjdbc/pgjdbc/actions/runs/16615037950/job/47044488575?pr=3748#step:4:776 ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-07-31 11:30 ` "eitch (@eitch)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: eitch (@eitch) @ 2025-07-31 11:30 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> I "fixed" the code, but the pipeline fails. Is the PR ok? Is something not correct? Looking at the AppVeyor build log, it seems to just be a broken pipeline due to resources and not due to the code, or did i miss something? ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-08-01 09:42 ` "davecramer (@davecramer)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: davecramer (@davecramer) @ 2025-08-01 09:42 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> appveyor failing is OK, code style not OK looks like you just have to delete line 17 ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-08-03 19:01 ` "sehrope (@sehrope)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: sehrope (@sehrope) @ 2025-08-03 19:01 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Thank you for the fix and the additional test. ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation @ 2025-08-04 07:34 ` "eitch (@eitch)" <[email protected]> 7 siblings, 0 replies; 9+ messages in thread From: eitch (@eitch) @ 2025-08-04 07:34 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Happy to help. When is a new release planned? ^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2025-08-04 07:34 UTC | newest] Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-07-29 14:38 [pgjdbc/pgjdbc] PR #3748: Fix #3747: Incorrect class comparison in PGXmlFactoryFactory validation "eitch (@eitch)" <[email protected]> 2025-07-29 18:02 ` "davecramer (@davecramer)" <[email protected]> 2025-07-30 06:22 ` "eitch (@eitch)" <[email protected]> 2025-07-31 06:05 ` "eitch (@eitch)" <[email protected]> 2025-07-31 08:39 ` "vlsi (@vlsi)" <[email protected]> 2025-07-31 11:30 ` "eitch (@eitch)" <[email protected]> 2025-08-01 09:42 ` "davecramer (@davecramer)" <[email protected]> 2025-08-03 19:01 ` "sehrope (@sehrope)" <[email protected]> 2025-08-04 07:34 ` "eitch (@eitch)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox