pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3776: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty.
4+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3776: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty.
@ 2025-08-19 14:29 "simon-greatrix (@simon-greatrix)" <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: simon-greatrix (@simon-greatrix) @ 2025-08-19 14:29 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

The setProperty method of BaseDataSource allows all properties to be set. The getProperty method does not allow the retrieval of: PG_HOST, PG_PORT, PG_DBNAME, USER, and PASSWORD. All properties that can be set should also be readable.

Create unit tests to verify that getting and setting properties works as expected.

Fixes: https://github.com/pgjdbc/pgjdbc/issues/3761


Sorry - I messed up my git repo. I should never have been merging from main. This re-opens https://github.com/pgjdbc/pgjdbc/pull/3762

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3776: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty.
@ 2025-08-27 07:02 ` "simon-greatrix (@simon-greatrix)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: simon-greatrix (@simon-greatrix) @ 2025-08-27 07:02 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

We seem to have lost momentum here. I have a fix with unit tests ready for merge. What are we waiting for?

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3776: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty.
@ 2025-09-09 07:21 ` "simon-greatrix (@simon-greatrix)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: simon-greatrix (@simon-greatrix) @ 2025-09-09 07:21 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

@vlsi  @davecramer  - is there anything I have to do for this merge request? All the checks pass, there are no conflicts - but you guys have gone silent on it?

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3776: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty.
@ 2025-09-09 10:09 ` "davecramer (@davecramer)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2025-09-09 10:09 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

@simon-greatrix just need to find some time to review it. 

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2025-09-09 10:09 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-19 14:29 [pgjdbc/pgjdbc] PR #3776: Fix: BaseDataSource.getProperty mirrors BaseDataSource.setProperty. "simon-greatrix (@simon-greatrix)" <[email protected]>
2025-08-27 07:02 ` "simon-greatrix (@simon-greatrix)" <[email protected]>
2025-09-09 07:21 ` "simon-greatrix (@simon-greatrix)" <[email protected]>
2025-09-09 10:09 ` "davecramer (@davecramer)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox