pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  
help / color / mirror / Atom feed
From: devs-lair (@devs-lair) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: [pgjdbc/pgjdbc] PR #3848: Fix updateRow() with OffsetTime and OffsetDataTime objects
Date: Sat, 25 Oct 2025 08:53:28 +0000
Message-ID: <[email protected]> (raw)

The documentation states that OffsetDateTime and OffsetTime must be used to work with time zone columns. TTIMETZ honestly stores the time zone. 

You can use the getObject(int, OffsetDataTime.class) method to obtain an OffsetDataTime class object, and everything works correctly. If you try to update a row with an object of this class (we update what we get), you'll get a ClassCastException. The SQL (UPDATE ...) query itself executes without error, and the data in the database itself is updated correctly. 

The error is specifically within PGResultSet.

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing](https://github.com/pgjdbc/pgjdbc/blob/master/CONTRIBUTING.md) document?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?

<!-- You can erase any parts of this template not applicable to your Pull Request. -->

### New Feature Submissions:

1. [ ] Does your submission pass tests?
2. [x] Does `./gradlew styleCheck` pass ?
3. [ ] Have you added your new test classes to an existing test suite in alphabetical order?

### Changes to Existing Features:

* [ ] Does this break existing behaviour? If so please explain.
* [x] Have you added an explanation of what your changes do and why you'd like us to include them?
* [x] Have you written new tests for your core changes, as applicable?
* [x] Have you successfully run tests with your changes locally?


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3848: Fix updateRow() with OffsetTime and OffsetDataTime objects
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox