pgjdbc/pgjdbc GitHub issues and pull requests (mirror)help / color / mirror / Atom feed
[pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl 6+ messages / 2 participants [nested] [flat]
* [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl @ 2025-10-30 18:47 "davecramer (@davecramer)" <[email protected]> 0 siblings, 0 replies; 6+ messages in thread From: davecramer (@davecramer) @ 2025-10-30 18:47 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> Attempt to comment and simplify the complex state machine logic in QueryExecutorImpl ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl @ 2025-11-05 13:14 ` "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2025-11-05 13:14 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java:507) Previously there was a code comment: ``` // If query has no resulting fields, it cannot fail with 'cached plan must not change result type' // thus no need to set a savepoint before such query ``` I think it makes sense keeping it, otherwise it is unclear why `getFields` implies `query might fail`. ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl @ 2025-11-05 13:16 ` "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2025-11-05 13:16 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java:526) I'm fine either way, however, extracting these lines to a separate method does not seem to improve readability ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl @ 2025-11-05 13:17 ` "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2025-11-05 13:17 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java:462) What was the reason to remove the comment? ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl @ 2025-11-05 13:17 ` "vlsi (@vlsi)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: vlsi (@vlsi) @ 2025-11-05 13:17 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java:466) What was the reason to remove the comment? ^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl @ 2025-11-06 12:38 ` "davecramer (@davecramer)" <[email protected]> 4 siblings, 0 replies; 6+ messages in thread From: davecramer (@davecramer) @ 2025-11-06 12:38 UTC (permalink / raw) To: pgjdbc/pgjdbc <[email protected]> (on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java:466) I put it back ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-11-06 12:38 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-30 18:47 [pgjdbc/pgjdbc] PR #3850: Comment and simplify the complex state machine logic in QueryExecutorImpl "davecramer (@davecramer)" <[email protected]> 2025-11-05 13:14 ` "vlsi (@vlsi)" <[email protected]> 2025-11-05 13:16 ` "vlsi (@vlsi)" <[email protected]> 2025-11-05 13:17 ` "vlsi (@vlsi)" <[email protected]> 2025-11-05 13:17 ` "vlsi (@vlsi)" <[email protected]> 2025-11-06 12:38 ` "davecramer (@davecramer)" <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox