pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: mjschwaiger (@mjschwaiger) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
Date: Mon, 19 Jan 2026 14:21:00 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

(on pgjdbc/src/main/java/org/postgresql/core/v3/QueryExecutorImpl.java)

Wouldn't it be more efficient to test the main/default case of AutoSave.NEVER first, thereby avoiding these string comparisons inside `isSpecialQuery` most of the time?
```
if (getAutoSave() == AutoSave.NEVER) {
    return false;
}
if (isSpecialQuery(query)) {
    return false;
}
```

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: [email protected], [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #3917: test: add autosave=always|never|conservative and cleanupSavepoints=true|false to the randomized CI jobs
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox