pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19
4+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19
@ 2026-02-09 10:44  "davecramer (@davecramer)" <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2026-02-09 10:44 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19
@ 2026-02-09 15:09  "vlsi (@vlsi)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: vlsi (@vlsi) @ 2026-02-09 15:09 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/PreparedStatementTest.java:473)

This looks inversed, doesn't it?
If you assume the test should execute with old versions only, we should have something like assume Maximum ServerVersion here

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19
@ 2026-02-09 15:24  "davecramer (@davecramer)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2026-02-09 15:24 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

ah, thanks, let me fix that

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19
@ 2026-02-09 15:50  "davecramer (@davecramer)" <[email protected]>
  2 siblings, 0 replies; 4+ messages in thread

From: davecramer (@davecramer) @ 2026-02-09 15:50 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

I looked at this and I think we need something like assumeServerVersionLessThan since saying assumeMaximumVersion (19) will fail for 19.1

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2026-02-09 15:50 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-09 10:44 [pgjdbc/pgjdbc] PR #3934: fix non-standard strings failing test for version 19 "davecramer (@davecramer)" <[email protected]>
2026-02-09 15:09 ` "vlsi (@vlsi)" <[email protected]>
2026-02-09 15:24 ` "davecramer (@davecramer)" <[email protected]>
2026-02-09 15:50 ` "davecramer (@davecramer)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox