pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: vlsi (@vlsi) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #3939: Add RequireServerVersion annotation for tests
Date: Mon, 23 Feb 2026 12:02:48 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
(on testkit/src/main/java/org/postgresql/test/annotations/EnabledForServerVersionRange.java:33)
> Worth at least validating that lt/lte aren't both set
An alternative option could be: `String min, String max, boolean minInclusive, boolean maxInclusive`.
Almost all the usages of the new annotation are `gte`, so we can go with `minInclusive = true`, `maxInclusive = false` by default. It would match the typical half-open ranges like in `List.subList(int fromIndex, int toIndex)`, and it would make `lte + lt` unrepresentable.
view thread (16+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] PR #3939: Add RequireServerVersion annotation for tests
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox