From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Wed, 09 Sep 2026 20:20:23 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654738@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/ExtendedSocketOptionAccessorImpl.java)
Three smaller points on these messages, whichever way the contract question on `ConnectionFactoryImpl` is resolved:
- not wrapped in `GT.tr` (see AGENTS.md, *Error messages*);
- they name the JDK option `TCP_KEEPCOUNT` rather than the connection property `tcpKeepAliveCount` that the user actually set;
- "only supported from JDK 11 onwards" is not the whole condition — see the comment on the java11 variant's `isSupported()`.
Today these three lines are also dead code: the tests gate the properties off on a Java 8 run, and `matrix.mjs` sets them only for `java_version >= 11`, so nothing executes them anywhere.