pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Wed, 09 Sep 2026 20:20:23 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654749@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>

(on pgjdbc/src/main/java/org/postgresql/core/ExtendedSocketOptionAccessor.java)

This interface is public in an exported package and is never used as a type — every call site goes through the concrete `ExtendedSocketOptionAccessorImpl.INSTANCE`, and the three `is*Supported()` methods have only test callers. Either make the interface the declared type, the way `LazyCleanerImpl implements LazyCleaner` does in the same `src/main/java11` source set, or drop it.

It also has no method documentation, and `isTcpKeepCountSupported()` is exactly the member whose contract a reader cannot infer from the name. The two implementations disagree on `throws IOException` as well (the java8 variant omits it).

view thread (85+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654749@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-3964-rc3972654749@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox