pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Wed, 09 Sep 2026 20:20:23 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654755@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>

(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java)

This swallow conflates "unset" with "not a number": a malformed value reads back as `null` while the connection still fails later, so the DataSource misreports its own configuration. Every other integer getter in this class uses `getIntNoCheck` and lets the parse error out (`getLoginTimeout`, `getConnectTimeout`, `getSocketTimeout`, ...). Please follow that, or document both meanings of `null` on `@return`.

view thread (85+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654755@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-3964-rc3972654755@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox