pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Wed, 09 Sep 2026 20:20:23 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654762@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>

(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java)

The first sentence of a doc comment is the summary, and it is what shows up in the generated summary table — so as written the row for `setTcpKeepAliveCount` never says what the method sets. Please lead with the summary and put the JDK qualifier after it. This is published API, so the comment ships as documentation.

The setter also needs the unit for the idle and interval siblings (seconds), and a word that `null` removes the property.

view thread (85+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654762@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-3964-rc3972654762@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox