From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Wed, 09 Sep 2026 20:20:23 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc3972654768@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
(on pgjdbc/src/main/java/org/postgresql/PGProperty.java:919)
Three factual problems in the text that is repeated here, in the description string, in `README.md` and in `use.md`.
1. "only when `jdk.net.ExtendedSocketOptions` is available" is not the condition that decides. The class itself is `@since 1.8`; the three fields are `@since 11`; and even on JDK 11+ the option may be absent from `socket.supportedOptions()`. Please state what actually holds — Linux and macOS from JDK 11, Windows from JDK 22 — and what the driver does when it does not.
2. Nothing says these have no effect unless `tcpKeepAlive=true`. That is the most important sentence for a reader, and it belongs on the `tcpKeepAlive` entry too. libpq states it for all three of its equivalents.
3. "the default value ... is typically 8" is copied from the JDK javadoc but reads as our claim once it is here, and it is wrong on Linux, where `tcp_keepalive_probes` defaults to 9. I would drop all three "typically N" sentences: we do not set the default, and "the value the operating system applies" is the fact a user can act on.
Please also state the unit (seconds) for the idle and interval properties.