From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 08:14:13 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009482@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/PGStream.java)
The 4-arg constructor does not need `@Deprecated`. It means "no keep-alive tuning", which the driver still needs: `QueryExecutorBase.sendQueryCancel` and five test classes were changed only to append `TcpKeepSettings.NONE`. Deprecating it fails downstream builds that use `-Xlint:deprecation -Werror`, and the replacement it points to takes `TcpKeepSettings`, whose Javadoc says it is not public API. Please drop the deprecation, point the `@deprecated` tags of the 2- and 3-argument constructors back at it, and revert the `NONE`-only edits. Keep the 5-arg constructor as an addition.