pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 08:14:13 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009500@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>

(on pgjdbc/src/main/java/org/postgresql/core/TcpKeepSettings.java)

Two problems with this warning.

- The text names "the JDK or the operating system", but the option is also missing when a `socketFactory` socket does not list it in `supportedOptions()`. `SocketWithoutExtendedOptions` models that case, and every junixsocket user hits it. Please name the socket class, `java.version` and `os.name` in the message, so a user can tell "before Java 11", "this JDK on this OS" and "this socket class" apart.
- It fires up to three times for every socket: every connection, every SSL or GSS fallback stream, every host in a multi-host URL, every pool refill. The cause does not change during the life of the JVM, so a shared configuration on Java 8 or on Windows before JDK 22 produces a steady stream of warnings nobody can act on. Please log it at WARNING once per property and cause, and at FINE after that.

view thread (85+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009500@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-3964-rc4346009500@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox