pg.ddx.io  GitHub: pgjdbc/pgjdbc (issues + PRs as email threads)  
help / color / mirror / Atom feed
From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 08:14:14 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009516@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>

(on pgjdbc/src/main/java/org/postgresql/PGProperty.java)

Two factual problems in the text repeated here, in the description strings, in the `BaseDataSource` setters, `use.md`, `README.md` and `CHANGELOG.md`:

- The last sentence contradicts "Has no effect unless `tcpKeepAlive` is `true`": `openConnectionImpl` calls `TcpKeepSettings.read(info)` on every connection, so `tcpKeepAlive=false&tcpKeepAliveIdle=0` fails with `tcpKeepAliveIdle parameter value must be a positive integer but was: 0`. Please either say "A value that is not a positive integer fails the connection, even when `tcpKeepAlive` is `false`", or validate the three only when `tcpKeepAlive` is `true`, as libpq does (it parses `keepalives_idle` only inside the `usekeepalives` branch).
- "Only takes effect on Linux and macOS from JDK 11 and on Windows from JDK 22" omits AIX, which supports the three options from JDK 21 (`AIXSocketOptions.keepAliveOptionsSupported0()`, JDK-8305089, `jdk-21+19`). Either add AIX or drop "Only".

The description strings are also 485 to 530 characters each, ending in the same platform clause three times, and they reach users through `DriverPropertyInfo`. A short description such as "The idle time in seconds before the first keep-alive probe. Requires tcpKeepAlive=true; when unset, the operating system's value applies." would do; the Javadoc can keep the detail.

view thread (85+ messages)  latest in thread

Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009516@github.com>
Permalink:  ../gh-pgjdbc-pgjdbc-3964-rc4346009516@github.com/

 · 


This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox