From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 08:14:14 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009524@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
(on docs/content/documentation/use.md)
The same sentence about platform support and warnings is repeated in all three entries. Please state it once, in the `tcpKeepAlive` entry, with the literal warning and error text a user will search for. Give each of the three entries one line: what it sets, the unit, "When unset, the operating system's value applies", and "Requires `tcpKeepAlive=true`; see `tcpKeepAlive` for platform support and invalid values". The `tcpKeepAlive` entry should also say why anyone tunes these: with the operating system's defaults the first probe goes out after about two hours idle.