From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 08:14:14 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009551@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/TcpKeepSettings.java)
Besides the libpq sentence, the class comment is wrong in two places:
- "A `null` value leaves the system default in place": `null` means the socket is left as the `socketFactory` created it, which is not necessarily the system default.
- `alive` is `null` only in `NONE`, because `read()` takes it from the primitive `getBoolean`. Neither `NONE` ("leaves every keep-alive setting of the socket unchanged, `SO_KEEPALIVE` included") nor the public `read()` (`@throws PSQLException` when a probe option is not a positive integer) is documented.