From: vlsi (@vlsi) <noreply+vlsi@github.com>
To: pgjdbc/pgjdbc <noreply+pgjdbc-pgjdbc@github.com>
Subject: Re: [pgjdbc/pgjdbc] PR #3964: feat: add tcpKeepAliveCount, tcpKeepAliveIdle and tcpKeepAliveInterval connection properties
Date: Thu, 22 Oct 2026 08:14:14 +0000
Message-ID: <gh-pgjdbc-pgjdbc-3964-rc4346009567@github.com> (raw)
In-Reply-To: <gh-pgjdbc-pgjdbc-3964@github.com>
References: <gh-pgjdbc-pgjdbc-3964@github.com>
(on pgjdbc/src/main/java/org/postgresql/core/ExtendedSocketOptionAccessor.java)
`ExtendedSocketOptionAccessor`, `ExtendedSocketIntOption` and both `ExtendedSocketOptionAccessorImpl` variants are referenced only from `org.postgresql.core` (main, java11 and tests). Yet they are `public` in a package the OSGi bundle exports (`-exportcontents: !org.postgresql.shaded.*, org.postgresql.*`). Making them package-private keeps the interface as the declared type and keeps them out of the API surface; only `TcpKeepSettings` needs to stay public.